Bug 36200 - Temporarily disable WebGL layout tests failing due to multisampling
Summary: Temporarily disable WebGL layout tests failing due to multisampling
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Critical
Assignee: Kenneth Russell
Depends on:
Reported: 2010-03-16 16:17 PDT by Kenneth Russell
Modified: 2010-03-16 16:39 PDT (History)
4 users (show)

See Also:

Patch (1.33 KB, patch)
2010-03-16 16:26 PDT, Kenneth Russell
eric: review+
Details | Formatted Diff | Diff
Revised patch (1.33 KB, patch)
2010-03-16 16:36 PDT, Kenneth Russell
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-03-16 16:17:49 PDT
After the introduction of multisampling support for WebGL in https://bugs.webkit.org/show_bug.cgi?id=33416 , a few layout tests are failing on some of the commit bots. Detection of buggy OpenGL implementations and workarounds for them are being investigated under https://bugs.webkit.org/show_bug.cgi?id=36194 , but in the interim to unblock the commit queue we need to disable these tests. (The overall code changes in 33416 were blocking other work and it is highly undesirable to roll them back.)
Comment 1 Kenneth Russell 2010-03-16 16:26:47 PDT
Created attachment 50850 [details]
Comment 2 Eric Seidel (no email) 2010-03-16 16:28:28 PDT
Comment on attachment 50850 [details]

I think Kenneth meant "build bots".  I don't think the commit-bot is failing these tests, but one of the build bots certainly is:

Either way, I think this is OK.

I would like to see the "fix it" bug instead of this bug listed in the Skipped list.  The ChangeLog could list both if you like.

Comment 3 Kenneth Russell 2010-03-16 16:36:11 PDT
Created attachment 50852 [details]
Revised patch

Revised patch mentioning the "real" bug for this fix (36194) rather than this one in the Skipped file. Leaving the ChangeLog to avoid confusing webkit-patch.
Comment 4 Eric Seidel (no email) 2010-03-16 16:37:20 PDT
Comment on attachment 50852 [details]
Revised patch

I shoudl have been more clear.  no need to re-post.  But still looks good!
Comment 5 Eric Seidel (no email) 2010-03-16 16:38:53 PDT
webkit-patch finds the "bug" for a diff by grepping the whole diff for bug numbers.  The first one it finds is the winner.

We might yet change that to only grep ChangeLogs, but for now that's how it works.
Comment 6 Kenneth Russell 2010-03-16 16:39:26 PDT
Committed r56093: <http://trac.webkit.org/changeset/56093>