Bug 36197 - Missing support for showing layer borders and repaint count on Windows
Summary: Missing support for showing layer borders and repaint count on Windows
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Enrica Casucci
Keywords: InRadar, PlatformOnly
Depends on:
Reported: 2010-03-16 15:24 PDT by Enrica Casucci
Modified: 2010-03-17 11:01 PDT (History)
1 user (show)

See Also:

Patch (8.18 KB, patch)
2010-03-16 15:40 PDT, Enrica Casucci
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2010-03-16 15:24:46 PDT
We need to add support to turn on and off the debug borders for the compositing layers on Windows.
Comment 1 Enrica Casucci 2010-03-16 15:40:56 PDT
Created attachment 50847 [details]
Comment 2 WebKit Review Bot 2010-03-16 15:45:22 PDT
Attachment 50847 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/graphics/win/GraphicsLayerCACF.cpp:42:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/win/WebPreferences.h:411:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 8 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2010-03-16 15:46:28 PDT
Comment on attachment 50847 [details]

> +            cg.setFillColor(Color(0, 0, 0, 0xff), DeviceColorSpace);

In a lot of other places we write this as Color::black instead.

Comment 4 Enrica Casucci 2010-03-17 11:01:43 PDT
Committed revision 56118.
Changed color to Color::black.