Host layout test flakiness dashboard in TestResultServer appengine. Flakiness dashboard is a tool (used by chromium) to monitor layout test status and help diagnose layout test regressions.
Created attachment 50845 [details] Proposed patch
Created attachment 50846 [details] Proposed patch - remove extra empty line
Created attachment 51466 [details] Proposed Patch
Comment on attachment 51466 [details] Proposed Patch + self.response.out.write(files[0].data) Mime type? Character set? + self.response.out.write("\n".join(errors)) XSS? + DashboardFile.delete_file(file) CSRF? Public delete file URL? + http://src.chromium.org/ Wrong project? + url = SVN_PATH_DASHBOARD + name URL encoding? Tests???
Created attachment 51545 [details] Patch per comment #4 Thanks for your good inputs, see my comments inline. (In reply to comment #4) > (From update of attachment 51466 [details]) > + self.response.out.write(files[0].data) > > Mime type? Character set? done > > + self.response.out.write("\n".join(errors)) > > XSS? ya, thanks for spotting this. Actually no need to write errors to response.out. The error messages is set in response.status. Removed. > > + DashboardFile.delete_file(file) > > CSRF? Public delete file URL? Added code to only allow AE admins to do this and only shows the "delete" links in file list for admin account. > > + http://src.chromium.org/ > > Wrong project? For now, the flakiness dashboard source code is still in chromium tree as it has code that are shared with other chromium tests. I think we will either move them upstream or have an upstream version so that non-chromium port can be benefit from this tool. > > + url = SVN_PATH_DASHBOARD + name > > URL encoding? done > > Tests??? There is a JAVA version of AE test framework but no python version yet (confirmed with Google AE team). I prefer waiting until a python version is released instead of making my own version for AE testing like datastore, blobstore, handler etc, thoughts? I could file a bug for adding test for AppEngine once it is ready if needed...
Created attachment 51547 [details] Correct app name and remove a few unused lines.
Comment on attachment 51547 [details] Correct app name and remove a few unused lines. Thanks for addressing my feedback. I'm not super excited about the dependency on the chromium source server, but I don't see a better solution in the meantime. We have another AppEngine app in QueueStatusServer, which also doesn't have any test coverage. I'm deathly afraid of touching it for that reason. A testing framework would certainly be nice. :)
Created attachment 51700 [details] Remove CRs in index.yaml Looks like mac-ews does not like CRs in index.yaml (generated by AE while I am running on windows), remove CRs in index.yaml. Hope this will make mac-ews happy.
Comment on attachment 51700 [details] Remove CRs in index.yaml Clearing flags on attachment: 51700 Committed r56635: <http://trac.webkit.org/changeset/56635>
All reviewed patches have been landed. Closing bug.