Bug 36185 – SVGResourceMarker needs to be moved to RenderersSVGResourceMarker

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Dirk Schulze]

SVGResourceMarker needs to be moved to RenderersSVGResourceMarker

[Dirk Schulze]

Created attachment 50831 [details]
patch

patch

[Nikolas Zimmermann]

Comment on attachment 50831 [details]
patch

Looks great! I guess you've updated all marker test results, if that's true I'm slightly worried that we never test angle != 0.0.
Though that doesn't block the patch, so r=me. Can you have a look at non-zero marker angles and create a testcase (safe to do afterwards...)
r=me.

[Eric Seidel (no email)]

Attachment 50831 [details] was posted by a committer and has review+, assigning to Dirk Schulze for commit.

[Eric Seidel (no email)]

Broke chromium mac compile due ot warning:
cc1plus: warnings being treated as errors
In file included from /Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave/chromium-mac-release/build/WebCore/WebCore.gyp/../svg/SVGAllInOne.cpp:136:
/Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave/chromium-mac-release/build/WebCore/WebCore.gyp/../svg/SVGStyledElement.cpp: In member function ‘void WebCore::SVGStyledElement::invalidateResources()’:
/Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave/chromium-mac-release/build/WebCore/WebCore.gyp/../svg/SVGStyledElement.cpp:227: warning: unused variable ‘svgStyle’

[Eric Seidel (no email)]

Caused 3 new failures on Qt bots:
http://build.webkit.org/results/Qt%20Linux%20Release/r56693%20(9220)/results.html

[Dirk Schulze]

Landed in 
http://trac.webkit.org/changeset/56693

Build-fix for Chromium-Mac and DRT-Updates for Qt landed in (mixed up linux
with mac in Changelog):
http://trac.webkit.org/changeset/56694

Closing bug now.