SVGResourceMarker needs to be moved to RenderersSVGResourceMarker
Created attachment 50831 [details]
Comment on attachment 50831 [details]
Looks great! I guess you've updated all marker test results, if that's true I'm slightly worried that we never test angle != 0.0.
Though that doesn't block the patch, so r=me. Can you have a look at non-zero marker angles and create a testcase (safe to do afterwards...)
Attachment 50831 [details] was posted by a committer and has review+, assigning to Dirk Schulze for commit.
Broke chromium mac compile due ot warning:
cc1plus: warnings being treated as errors
In file included from /Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave/chromium-mac-release/build/WebCore/WebCore.gyp/../svg/SVGAllInOne.cpp:136:
/Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave/chromium-mac-release/build/WebCore/WebCore.gyp/../svg/SVGStyledElement.cpp: In member function â€˜void WebCore::SVGStyledElement::invalidateResources()â€™:
/Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave/chromium-mac-release/build/WebCore/WebCore.gyp/../svg/SVGStyledElement.cpp:227: warning: unused variable â€˜svgStyleâ€™
Caused 3 new failures on Qt bots:
Build-fix for Chromium-Mac and DRT-Updates for Qt landed in (mixed up linux
with mac in Changelog):
Closing bug now.