Bug 36173 – [GTK] http/history tests are failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Sergio Villar Senin]

Basically due to two issues:
   * the LayoutController is not returning the actual back forward list count
   * there is no way to clear the back forward list

[Sergio Villar Senin]

Created attachment 50803 [details]
Patch that fixes all the http/history test cases

Basically this patch does two very basic things:
   * return the actual count of history items in LayoutTestController
   * clear the back forward list (history) each time we run a test

[WebKit Review Bot]

Attachment 50803 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/gtk/ChangeLog:13:  Line contains tab character.  [whitespace/tab] [5]
WebKit/gtk/webkit/webkitwebbackforwardlist.h:114:  Extra space before ( in function call  [whitespace/parens] [4]
WebKitTools/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
WebKitTools/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
WebKitTools/ChangeLog:15:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 5 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sergio Villar Senin]

Created attachment 50804 [details]
Patch that fixes all the http/history Skipped tests

New version of the patch with some style corrections

[WebKit Review Bot]

Attachment 50804 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/gtk/ChangeLog:13:  Line contains tab character.  [whitespace/tab] [5]
WebKit/gtk/webkit/webkitwebbackforwardlist.h:114:  Extra space before ( in function call  [whitespace/parens] [4]
WebKitTools/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
WebKitTools/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
WebKitTools/ChangeLog:15:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 5 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Xan Lopez]

Comment on attachment 50804 [details]
Patch that fixes all the http/history Skipped tests

Commented this on jabber, we are going to do it in two patches (one adding new API + unit test, other fixing DRT). So r- for now.

[Sergio Villar Senin]

Created attachment 50814 [details]
Added new API to clear the back forward list

Patch that adds a new API to clear the back forward list + unit test

[Sergio Villar Senin]

Created attachment 50815 [details]
Fix the http/history test cases

Patch that fixes the http/history test cases
   * Return the actual history item count
   * Removed tests from the Skipped file

[WebKit Review Bot]

Attachment 50815 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/858032

[Eric Seidel (no email)]

Comment on attachment 50815 [details]
Fix the http/history test cases

OK.

[Sergio Villar Senin]

Created attachment 51608 [details]
Adds new API to clear back forward list

Changes from the original patch:
   * addItem1 renamed to addItem
   * Since version 1.1.24 -> 1.1.30

[WebKit Review Bot]

Attachment 51608 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/gtk/webkit/webkitwebbackforwardlist.h:114:  Extra space before ( in function call  [whitespace/parens] [4]
WARNING: File exempt from style guide. Skipping: "WebKit/gtk/tests/testwebbackforwardlist.c"
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Xan Lopez]

Comment on attachment 51608 [details]
Adds new API to clear back forward list

r=me

[WebKit Commit Bot]

Comment on attachment 51608 [details]
Adds new API to clear back forward list

Clearing flags on attachment: 51608

Committed r56531: <http://trac.webkit.org/changeset/56531>

[Eric Seidel (no email)]

Comment on attachment 50815 [details]
Fix the http/history test cases

Actually, I'd much rather some Gtk person landed this by hand.

[Adam Barth]

Comment on attachment 50815 [details]
Fix the http/history test cases

In that case, we should mark it cq-.

[Adam Barth]

Comment on attachment 50815 [details]
Fix the http/history test cases

This has been setting in pending-commit for over a month.  If you'd like to land this patch, please do so with Eric's review.

Clearing the review flag since this isn't doing anyone any good languishing in pending-commit.

[Xan Lopez]

Comment on attachment 50815 [details]
Fix the http/history test cases

This should work now, let's try.

[WebKit Commit Bot]

Comment on attachment 50815 [details]
Fix the http/history test cases

Clearing flags on attachment: 50815

Committed r70039: <http://trac.webkit.org/changeset/70039>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.