Bug 36169 - CCommit queue should ignore (probably red) builders when landing rollouts
Summary: CCommit queue should ignore (probably red) builders when landing rollouts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-16 09:16 PDT by Adam Barth
Modified: 2010-03-17 20:24 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.73 KB, patch)
2010-03-16 09:18 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (2.78 KB, patch)
2010-03-17 13:05 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-03-16 09:16:43 PDT
CCommit queue should ignore (probably red) builders when landing rollouts
Comment 1 Adam Barth 2010-03-16 09:18:43 PDT
Created attachment 50800 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-03-17 12:46:55 PDT
Comment on attachment 50800 [details]
Patch

 213                 # We pass --no-update here because we've already validated

should say "in the normal case" or something instead of "here" to designate that it's the commit-queue case instead of the rollout case.
Comment 3 Adam Barth 2010-03-17 13:05:54 PDT
Created attachment 50946 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2010-03-17 20:24:54 PDT
Comment on attachment 50946 [details]
Patch for landing

Clearing flags on attachment: 50946

Committed r56145: <http://trac.webkit.org/changeset/56145>
Comment 5 WebKit Commit Bot 2010-03-17 20:24:58 PDT
All reviewed patches have been landed.  Closing bug.