Bug 36155 - Let commit-queue land rollout patches even when the tree is red
Summary: Let commit-queue land rollout patches even when the tree is red
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-15 22:39 PDT by Adam Barth
Modified: 2010-03-15 22:55 PDT (History)
1 user (show)

See Also:

Attachments
Patch (7.61 KB, patch)
2010-03-15 22:42 PDT, Adam Barth 		eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-03-15 22:39:59 PDT 
Let commit-queue land rollout patches even when the tree is red
Comment 1 Adam Barth 2010-03-15 22:42:19 PDT 
Created attachment 50762 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-03-15 22:49:46 PDT 
Comment on attachment 50762 [details]
Patch

Use a constant:
 101         return self.name().startswith("ROLLOUT ")

This is no where near 80c:
 154         valid_patches = self.committer_validator.patches_after_rejecting_invalid_commiters_and_reviewers(all_patches)

You haz made the uglies!
186         if not patch.is_rollout() and (not self._builders_are_green() or not self._can_build_and_test() or not self._builders_are_green()):

patch?
 52     "name": "Path1",
Comment 3 Adam Barth 2010-03-15 22:55:50 PDT 
Committed r56040: <http://trac.webkit.org/changeset/56040>