Remove calls to setPage(0) - these were causing tst_qwebpage to
segfault at acceptNavigationRequest() and errorPageExtension*().
Created attachment 50737 [details]
Fixing unstable tests is always a good thing but usually it is better to fix the reason of a failure, I think.
Here is the interesting bit of the crash:
Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7022dc2 in QWebView::setPage (this=0x71f3a0, page=0x0) at WebKit/qt/Api/qwebview.cpp:401
(gdb) bt full
#0 0x00007ffff7022dc2 in QWebView::setPage (this=0x71f3a0, page=0x0) at WebKit/qt/Api/qwebview.cpp:401
Created attachment 50746 [details]
Actually fix the bug per Jakub's kind suggestion!
Comment on attachment 50746 [details]
Why the indent change?
Manually committed: http://trac.webkit.org/changeset/56060
(In reply to comment #4)
> (From update of attachment 50746 [details])
> Why the indent change?
It's moved into an if block.