Bug 36134 - Drop out of compositing mode when no elements need to composite
Summary: Drop out of compositing mode when no elements need to composite
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-03-15 13:34 PDT by Simon Fraser (smfr)
Modified: 2010-03-15 14:49 PDT (History)
0 users

See Also:

Attachments
Patch (6.06 KB, patch)
2010-03-15 14:29 PDT, Simon Fraser (smfr) 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-03-15 13:34:39 PDT 
Currently we never go out of compositing mode on a given page, even if no elements need to be composited. This means that we keep a layer-backed view subview of the WebHTMLView around, which can impact resize performance.
Comment 1 Simon Fraser (smfr) 2010-03-15 14:29:19 PDT 
Created attachment 50740 [details]
Patch
Comment 2 mitz 2010-03-15 14:39:27 PDT 
Comment on attachment 50740 [details]
Patch


> +            } else {
> +                m_rootPlatformLayer->setChildren(childList);
> +            }

Braces around one-line block.
Comment 3 Simon Fraser (smfr) 2010-03-15 14:47:46 PDT 
http://trac.webkit.org/changeset/56017
Comment 4 Simon Fraser (smfr) 2010-03-15 14:49:02 PDT 
<rdar://problem/7748315>