RESOLVED INVALID 36127
purgeInactiveFontData() should also prune glyph data 
https://bugs.webkit.org/show_bug.cgi?id=36127
Summary purgeInactiveFontData() should also prune glyph data
Yong Li
Reported 2010-03-15 12:36:04 PDT
FontCache::purgeInactiveFontData() is called to delete some inactive SimpleFontData objects. But the deleted SimpleFontData objects' glyph data are still left in glyph page tree. I think this can be considered as leaks. Following code fixes it. - for (size_t i = 0; i < fontDataToDeleteCount; ++i) + for (size_t i = 0; i < fontDataToDeleteCount; ++i) { + GlyphPageTreeNode::pruneTreeFontData(fontDataToDelete[i]); delete fontDataToDelete[i]; + } Patch is following
Attachments
the patch (1.23 KB, patch)
2010-03-15 12:40 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yong Li
Comment 1 2010-03-15 12:40:30 PDT
Created attachment 50722 [details] the patch
Yong Li
Comment 2 2010-03-15 13:18:12 PDT
Comment on attachment 50722 [details] the patch review canceled. seems it's already called SimpleFontData's dtor. need more investigation on why this code helps
Yong Li
Comment 3 2010-03-15 13:27:02 PDT
sorry. seems like a false alarm. will reopen it if necessary
Note You need to log in before you can comment on or make changes to this bug.