As it is today it is not possible to the menulists popups to tell SelectElement that more then one option is selected. If you select one the other ones selected state will turn off. For <select multiple> I needed to extend the API used by menulist popups. This is the first step.
Created attachment 50717 [details] patch
Created attachment 50718 [details] patch 2
Comment on attachment 50718 [details] patch 2 r=me
Comment on attachment 50718 [details] patch 2 Rejecting patch 50718 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Antti Koivisto', '--force']" exit_code: 1 Last 500 characters of output: + WebCore/dom/SelectElement.cpp | 93 +++++++++++++++++++++------------------- WebCore/dom/SelectElement.h | 3 + 3 files changed, 72 insertions(+), 44 deletions(-) ------------------------------------------------------------------- patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/dom/SelectElement.cpp patching file WebCore/dom/SelectElement.h Hunk #1 FAILED at 97. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/dom/SelectElement.h.rej Full output: http://webkit-commit-queue.appspot.com/results/885008
We will need an updated patch to land this via the commit queue.
*** Bug 34842 has been marked as a duplicate of this bug. ***
Created attachment 50808 [details] (committed in r56116) patch 3 Adjusting previous patch.
(In reply to comment #5) > We will need an updated patch to land this via the commit queue. Why is it taking so long for the bots to check this patch and for landing?
Comment on attachment 50808 [details] (committed in r56116) patch 3 since the CQ is stuck, I committed it manually on behalf of Luiz. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/dom/SelectElement.cpp M WebCore/dom/SelectElement.h Committed r56116
The commit-queue gets stuck when people break the build. You can see the status of the queue here: http://webkit-commit-queue.appspot.com/