Bug 36121 - [Qt] Make WebKit scrollbars work with tiling
Summary: [Qt] Make WebKit scrollbars work with tiling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P3 Normal
Assignee: Antti Koivisto
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-03-15 09:05 PDT by Antti Koivisto
Modified: 2010-03-16 09:57 PDT (History)
3 users (show)

See Also:


Attachments
patch (11.72 KB, patch)
2010-03-15 09:16 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
updated patch (11.77 KB, patch)
2010-03-16 05:28 PDT, Antti Koivisto
hausmann: review+
Details | Formatted Diff | Diff
Screenshot (77.90 KB, image/png)
2010-03-16 08:57 PDT, Simon Hausmann
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2010-03-15 09:05:50 PDT
Currently tiling only works correctly when the QGraphicsWebView is in resizesToContent mode. It should work without too, using the scrollbar overlay (already implemented for accelerated compositing).
Comment 1 Antti Koivisto 2010-03-15 09:16:40 PDT
Created attachment 50713 [details]
patch
Comment 2 Simon Hausmann 2010-03-15 09:50:57 PDT
This works quite well now! The vertical scrollbar is broken for me though. Do you see that, too?
Comment 3 Kenneth Rohde Christiansen 2010-03-15 14:21:54 PDT
Nice patch!
Comment 4 Simon Hausmann 2010-03-16 01:39:45 PDT
Comment on attachment 50713 [details]
patch


> +void QGraphicsWebViewPrivate::createOrDeleteOverlay()
> +{
> +    bool useOverlay = false;
> +#if USE(ACCELERATED_COMPOSITING)
> +    useOverlay = useOverlay || rootGraphicsLayer;
> +#endif
> +#if ENABLE(TILED_BACKING_STORE)
> +    useOverlay = useOverlay || QWebFramePrivate::core(q->page()->mainFrame())->tiledBackingStore();

Isn't another condition that we need the overlay only if we're _not_ in resizesToContents mode?
Comment 5 Antti Koivisto 2010-03-16 05:09:00 PDT
(In reply to comment #2)
> This works quite well now! The vertical scrollbar is broken for me though. Do
> you see that, too?

No, both scrollbars look and work fine (this is on mac). Anything special I need to do to see this?
Comment 6 Antti Koivisto 2010-03-16 05:28:31 PDT
Created attachment 50784 [details]
updated patch
Comment 7 Antti Koivisto 2010-03-16 05:29:13 PDT
Comment on attachment 50784 [details]
updated patch

fixed the resizesToContents bug Simon noticed
Comment 8 Simon Hausmann 2010-03-16 08:56:24 PDT
(In reply to comment #5)
> (In reply to comment #2)
> > This works quite well now! The vertical scrollbar is broken for me though. Do
> > you see that, too?
> 
> No, both scrollbars look and work fine (this is on mac). Anything special I
> need to do to see this?

Hmmm, I see it happening on Linux with the Oxygen style. For some reason it doesn't happen with the other styles.
Comment 9 Simon Hausmann 2010-03-16 08:57:58 PDT
Created attachment 50797 [details]
Screenshot

Attached is a screenshot of the bug. It looks like it only affects the vertical scrollbar, and I think that could happen if the geometries passed to are weird.
Comment 10 Antti Koivisto 2010-03-16 09:57:27 PDT
Sending        WebCore/ChangeLog
Sending        WebCore/page/Frame.cpp
Sending        WebKit/qt/Api/qgraphicswebview.cpp
Sending        WebKit/qt/Api/qwebframe.cpp
Sending        WebKit/qt/Api/qwebframe_p.h
Sending        WebKit/qt/ChangeLog
Transmitting file data ......
Committed revision 56068.