Bug 36119 - Method name and parameter name mistakes from recent SPI addition
Summary: Method name and parameter name mistakes from recent SPI addition
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: John Sullivan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-15 08:22 PDT by John Sullivan
Modified: 2010-03-15 08:41 PDT (History)
0 users

See Also:

Attachments
Patch to rename recently-added methods, instance variable, and parameters. (7.17 KB, patch)
2010-03-15 08:35 PDT, John Sullivan 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Sullivan 2010-03-15 08:22:34 PDT 
A method named "setAllowScrollersToOverlapContent:" was recently added as Mac-only SPI in WebFrame and WebDynamicScrollBarsView. This name should be "setAllows…" to match other usage. Also, parameters for -[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:] and -setAlwaysHideVerticalScroller: (which were added together with -setAllowScrollersToOverlapContent:) have reversed boolean-style names in the implementation, which is confusing.
Comment 1 John Sullivan 2010-03-15 08:35:23 PDT 
Created attachment 50710 [details]
Patch to rename recently-added methods, instance variable, and parameters.

These methods are used only on Safari at this point. I will also update Safari for these renamings.
Comment 2 John Sullivan 2010-03-15 08:41:51 PDT 
Committed in 55997.