Bug 36117 – Web Inspector: migrate to native styles inspector in order to inspect styles from foreighn domains.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

(This will be used for audits too)

[Pavel Feldman]

Created attachment 50708 [details]
[PATCH] Proposed change.

[WebKit Review Bot]

Attachment 50708 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/inspector/InspectorDOMAgent.cpp:40:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/inspector/InspectorDOMAgent.cpp:773:  One line control clauses should not use braces.  [whitespace/braces] [4]
WebCore/inspector/InspectorDOMAgent.cpp:853:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/inspector/InspectorDOMAgent.cpp:867:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 4 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Seidel (no email)]

Attachment 50708 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/869002

[WebKit Review Bot]

Attachment 50708 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/885001

[Timothy Hatcher]

Comment on attachment 50708 [details]
[PATCH] Proposed change.

> +    for (unsigned i = 0; …

Use size_t instead for for loops.


> +    bool isUserAgent = parentStyleSheet && !parentStyleSheet->ownerNode() && parentStyleSheet->href().isEmpty();
> +    bool isUser = parentStyleSheet && parentStyleSheet->ownerNode() && parentStyleSheet->ownerNode()->nodeName() == "#document";

I suspect there is a more direct way to get this info now that we are in native code.


I lament to loss of easier to write JavaScript…

[Timothy Hatcher]

Make sure to fix the flagged style errors and the build errors.

[Pavel Feldman]

Created attachment 50744 [details]
[PATCH] Patch to land.

[Eric Seidel (no email)]

Comment on attachment 50708 [details]
[PATCH] Proposed change.

Cleared Timothy Hatcher's review+ from obsolete attachment 50708 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[Joseph Pecoraro]

(In reply to comment #6)
> Make sure to fix the flagged style errors and the build errors.

Also, is it really "foreighn" or should it be "foreign" or just "any domain"? It would be nice to update the bug + ChangeLog if that is a typo.

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/inspector/styles-iframe.html
	M	WebCore/ChangeLog
	M	WebCore/bindings/js/ScriptValue.h
	M	WebCore/bindings/v8/ScriptValue.h
	M	WebCore/inspector/InspectorBackend.cpp
	M	WebCore/inspector/InspectorBackend.h
	M	WebCore/inspector/InspectorBackend.idl
	M	WebCore/inspector/InspectorDOMAgent.cpp
	M	WebCore/inspector/InspectorDOMAgent.h
	M	WebCore/inspector/InspectorFrontend.cpp
	M	WebCore/inspector/InspectorFrontend.h
	M	WebCore/inspector/front-end/DOMAgent.js
	M	WebCore/inspector/front-end/ElementsTreeOutline.js
	M	WebCore/inspector/front-end/InjectedScript.js
	M	WebCore/inspector/front-end/MetricsSidebarPane.js
	M	WebCore/inspector/front-end/StylesSidebarPane.js
	M	WebCore/inspector/front-end/inspector.js
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/src/js/InspectorControllerImpl.js
Committed r56049