Bug 36112 - Make PlatformMedia a typedef
Summary: Make PlatformMedia a typedef
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-15 03:01 PDT by Philippe Normand
Modified: 2010-05-10 07:52 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch (11.67 KB, patch)
2010-05-10 03:04 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2010-03-15 03:01:31 PDT 
From Bug 35333, interesting comments especially in https://bugs.webkit.org/show_bug.cgi?id=35333#c8 and https://bugs.webkit.org/show_bug.cgi?id=35333#c10
Comment 1 Philippe Normand 2010-05-10 02:48:07 PDT 
I will send a patch to make PlatformMedia a typedef. As I think we agreed with Eric (correct me if I'm wrong!) it doesn't make much sense for it to be a structure.
Comment 2 Philippe Normand 2010-05-10 03:04:18 PDT 
Created attachment 55533 [details]
proposed patch
Comment 3 Jer Noble 2010-05-10 07:35:06 PDT 
Phillipe, please take a look at the patch in https://bugs.webkit.org/show_bug.cgi?id=38689.  

Windows WebCore now has multiple MediaPlayerPrivate engines created at runtime, each which needs to return a different type of PlatformMedia.  Defining these types at compile-time by platform doesn't allow this.  But adding a GStreamer specific type to the struct in the patch above would be very simple.
Comment 4 Philippe Normand 2010-05-10 07:51:40 PDT 
Ah well... then I guess I should mark this bug as invalid. For GStreamer the PlatformMedia stuff doesn't help much. I plan to propose a new API in the MediaPlayer to enter/exit fullscreen. The player would provide to the "client" a PlatformFullscreenWindow pointer. Anyway this is for another bug :)