Bug 36072 - [OpenVG] Add support for decoding and drawing images
Summary: [OpenVG] Add support for decoding and drawing images
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Jakob Petsovits
Depends on:
Blocks: 33987
  Show dependency treegraph
Reported: 2010-03-12 14:16 PST by Jakob Petsovits
Modified: 2010-05-17 12:11 PDT (History)
4 users (show)

See Also:

Patch (30.32 KB, patch)
2010-03-12 14:18 PST, Jakob Petsovits
no flags Details | Formatted Diff | Diff
Patch (30.41 KB, patch)
2010-03-29 08:56 PDT, Jakob Petsovits
staikos: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jakob Petsovits 2010-03-12 14:16:06 PST
Image support is still missing in the OpenVG backend (as is ImageBuffer and lots of features, but those are subject to future bugs). As you might guess, this patch has a shot at that shortcoming. It's currently duplicating memory - both the decoded buffer and the VGImage are storing the same pixel data, which is bad. But the patch is large enough already, so I'll wait with the "better" version until this one has been landed. Image pattern drawing for arbitrary-size images is also not quite trivial and will come in a follow-up patch as well.
Comment 1 Jakob Petsovits 2010-03-12 14:18:02 PST
Created attachment 50633 [details]
Comment 2 Jakob Petsovits 2010-03-29 08:56:41 PDT
Created attachment 51918 [details]
Comment 3 Jakob Petsovits 2010-03-29 08:58:37 PDT
The above fixes a couple of issues noticed by Dirk, who suggests that Olliej or someone else should take a look at this patch as well. Still waiting for review, thanks!
Comment 4 George Staikos 2010-04-06 19:53:14 PDT
Looks good, and I know you have some additional patches to follow this which I hope will show up quickly. :)
Comment 5 Eric Seidel (no email) 2010-04-06 23:44:59 PDT
Attachment 51918 [details] was posted by a committer and has review+, assigning to Jakob Petsovits for commit.
Comment 6 Eric Seidel (no email) 2010-05-17 00:55:42 PDT
Looks like this has been in pending-commit for over a month.  Did this get landed already?  Should it just be commit-queued?
Comment 7 Jakob Petsovits 2010-05-17 11:23:46 PDT
Was not landed yet. I'll land it today, and will try harder to get the rest of OpenVG patches upstream as well.
Comment 8 Jakob Petsovits 2010-05-17 12:11:45 PDT
Committed r59619: <http://trac.webkit.org/changeset/59619>