Bug 36069 - Eliminate InlineRunBox
: Eliminate InlineRunBox
Status: RESOLVED FIXED
: WebKit
Layout and Rendering
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-03-12 11:54 PST by
Modified: 2010-03-12 12:30 PST (History)


Attachments
Patch to remove InlineRunBox (36.12 KB, patch)
2010-03-12 12:12 PST, Dave Hyatt
mitz: review+
hyatt: commit‑queue-
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-03-12 11:54:04 PST
It's an unnecessary class that is complicating the line box hierarchy.  It needs to go.
------- Comment #1 From 2010-03-12 12:12:38 PST -------
Created an attachment (id=50620) [details]
Patch to remove InlineRunBox
------- Comment #2 From 2010-03-12 12:17:38 PST -------
Attachment 50620 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WARNING: Could not read file. Skipping: "WebCore/rendering/InlineRunBox.h"
WebCore/rendering/RenderLineBoxList.cpp:324:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/rendering/InlineFlowBox.h:176:  One space before end of line comments  [whitespace/comments] [5]
WebCore/rendering/InlineFlowBox.h:177:  One space before end of line comments  [whitespace/comments] [5]
WebCore/rendering/InlineTextBox.h:123:  One space before end of line comments  [whitespace/comments] [5]
WebCore/rendering/InlineTextBox.h:124:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 5 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #3 From 2010-03-12 12:30:05 PST -------
Fixed in r55928.