Bug 36069 - Eliminate InlineRunBox
Summary: Eliminate InlineRunBox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-12 11:54 PST by Dave Hyatt
Modified: 2010-03-12 12:30 PST (History)
1 user (show)

See Also:

Attachments
Patch to remove InlineRunBox (36.12 KB, patch)
2010-03-12 12:12 PST, Dave Hyatt 		mitz: review+
hyatt: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-03-12 11:54:04 PST 
It's an unnecessary class that is complicating the line box hierarchy.  It needs to go.
Comment 1 Dave Hyatt 2010-03-12 12:12:38 PST 
Created attachment 50620 [details]
Patch to remove InlineRunBox
Comment 2 WebKit Review Bot 2010-03-12 12:17:38 PST 
Attachment 50620 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WARNING: Could not read file. Skipping: "WebCore/rendering/InlineRunBox.h"
WebCore/rendering/RenderLineBoxList.cpp:324:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/rendering/InlineFlowBox.h:176:  One space before end of line comments  [whitespace/comments] [5]
WebCore/rendering/InlineFlowBox.h:177:  One space before end of line comments  [whitespace/comments] [5]
WebCore/rendering/InlineTextBox.h:123:  One space before end of line comments  [whitespace/comments] [5]
WebCore/rendering/InlineTextBox.h:124:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 5 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2010-03-12 12:30:05 PST 
Fixed in r55928.