Bug 36050 - Add the possibility for a head and footer section to create_jit_stubs
Summary: Add the possibility for a head and footer section to create_jit_stubs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 34953
  Show dependency tree / graph
 
Reported: 2010-03-12 00:21 PST by Patrick R. Gansterer
Modified: 2010-06-25 00:30 PDT (History)
5 users (show)

See Also:

Attachments
The patch (1.53 KB, patch)
2010-03-12 00:22 PST, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-03-12 00:21:11 PST 
see patch
Comment 1 Patrick R. Gansterer 2010-03-12 00:22:30 PST 
Created attachment 50580 [details]
The patch
Comment 2 Laszlo Gombos 2010-03-12 05:37:52 PST 
Patrick, can you describe the motivation behind this change ? Which port will use this feature and how will this feature will be used ? Thanks.
Comment 3 Patrick R. Gansterer 2010-03-12 05:41:25 PST 
(In reply to comment #2)
> Patrick, can you describe the motivation behind this change ? Which port will
> use this feature and how will this feature will be used? Thanks.
It's for bug 34953. I need to insert sth before and sth after the DEFINE_STUB_FUNCTION.
Comment 4 Eric Seidel (no email) 2010-03-15 15:22:04 PDT 
Comment on attachment 50580 [details]
The patch

The ChangeLog should really explain the "why".  Comments in the bug are nice, but not as accessible during reviews or during later svn annotates.
Comment 5 Eric Seidel (no email) 2010-03-25 01:43:30 PDT 
CCing the JIT ninjas.
Comment 6 Eric Seidel (no email) 2010-05-09 14:54:48 PDT 
Comment on attachment 50580 [details]
The patch

Is this used for anything?  How can this be tested, or at least proven to do something useful. :)
Comment 7 Patrick R. Gansterer 2010-05-09 15:05:27 PDT 
(In reply to comment #6)
> (From update of attachment 50580 [details])
> Is this used for anything?  How can this be tested, or at least proven to do something useful. :)
This is only necessary for bug 34953. The assembler file for WinCE ARM JIT needs a part before (at least "   AREA Trampoline, CODE") and a part after the "DEFINE_STUB_FUNCTION implementations" ("   END").

Maybe you have a better solution for this?? Otherwise it can be useful ;-)
Comment 8 WebKit Commit Bot 2010-06-25 00:30:27 PDT 
Comment on attachment 50580 [details]
The patch

Clearing flags on attachment: 50580

Committed r61838: <http://trac.webkit.org/changeset/61838>
Comment 9 WebKit Commit Bot 2010-06-25 00:30:32 PDT 
All reviewed patches have been landed.  Closing bug.