Bug 36040 - More open-source image decoder cleanup
Summary: More open-source image decoder cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Peter Kasting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-11 16:33 PST by Peter Kasting
Modified: 2010-03-15 13:09 PDT (History)
1 user (show)

See Also:

Attachments
patch v1 (16.54 KB, patch)
2010-03-11 16:43 PST, Peter Kasting 		no flags Details | Formatted Diff | Diff
patch v2 (16.90 KB, patch)
2010-03-11 16:50 PST, Peter Kasting 		abarth: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Kasting 2010-03-11 16:33:39 PST 
Patch coming to clean up a bunch of small bits, to be described in more detail on the patch itself.
Comment 1 Peter Kasting 2010-03-11 16:43:04 PST 
Created attachment 50560 [details]
patch v1

Details on the ChangeLog.  Half of this is making things simpler, the other half is making things consistent between the different decoders.
Comment 2 WebKit Review Bot 2010-03-11 16:47:02 PST 
Attachment 50560 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:144:  num_bytes is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Peter Kasting 2010-03-11 16:50:30 PST 
Created attachment 50561 [details]
patch v2

It's always a judgment call which style issues in the JPEGImageDecoder file to fix; fixed this one because it's our member function rather than one of the C API functions libjpeg calls directly.
Comment 4 Adam Barth 2010-03-13 02:00:07 PST 
Comment on attachment 50561 [details]
patch v2

Nice.
Comment 5 Peter Kasting 2010-03-15 13:09:00 PDT 
Fixed in r56007.