RESOLVED FIXED Bug 36040
More open-source image decoder cleanup 
https://bugs.webkit.org/show_bug.cgi?id=36040
Summary More open-source image decoder cleanup
Peter Kasting
Reported 2010-03-11 16:33:39 PST
Patch coming to clean up a bunch of small bits, to be described in more detail on the patch itself.
Attachments
patch v1 (16.54 KB, patch)
2010-03-11 16:43 PST, Peter Kasting 		no flags
DetailsFormatted DiffDiff
patch v2 (16.90 KB, patch)
2010-03-11 16:50 PST, Peter Kasting 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peter Kasting
Comment 1 2010-03-11 16:43:04 PST
Created attachment 50560 [details] patch v1 Details on the ChangeLog. Half of this is making things simpler, the other half is making things consistent between the different decoders.
WebKit Review Bot
Comment 2 2010-03-11 16:47:02 PST
Attachment 50560 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:144: num_bytes is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Peter Kasting
Comment 3 2010-03-11 16:50:30 PST
Created attachment 50561 [details] patch v2 It's always a judgment call which style issues in the JPEGImageDecoder file to fix; fixed this one because it's our member function rather than one of the C API functions libjpeg calls directly.
Adam Barth
Comment 4 2010-03-13 02:00:07 PST
Comment on attachment 50561 [details] patch v2 Nice.
Peter Kasting
Comment 5 2010-03-15 13:09:00 PDT
Fixed in r56007.
Note You need to log in before you can comment on or make changes to this bug.