Bug 36028 - Crash with uniform array test
Summary: Crash with uniform array test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-11 12:16 PST by Kenneth Russell
Modified: 2010-07-09 09:43 PDT (History)
4 users (show)

See Also:

Attachments
Test case (8.75 KB, text/plain)
2010-06-28 13:30 PDT, Kenneth Russell 		no flags Details
Patch (8.10 KB, patch)
2010-07-08 19:03 PDT, Kenneth Russell 		dglazkov: review+
kbr: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-03-11 12:16:36 PST 
The attached test case crashes the Chromium WebGL port in the V8 custom bindings.
Comment 1 Kenneth Russell 2010-06-28 13:30:11 PDT 
Created attachment 59931 [details]
Test case
Comment 2 Kenneth Russell 2010-07-08 19:03:29 PDT 
Created attachment 60995 [details]
Patch

From the ChangeLog:

Fixed type tests and casting of incoming arrays. Fixed crash when null WebGLUniform is passed to getUniform. Separated calling wrong uniform*fv entry point from calling with non-array. Updated test expectations.
Comment 3 Dimitri Glazkov (Google) 2010-07-09 09:39:01 PDT 
Comment on attachment 60995 [details]
Patch

ok.
Comment 4 Kenneth Russell 2010-07-09 09:43:58 PDT 
Committed r62961: <http://trac.webkit.org/changeset/62961>