Bug 36025 - accessibilityIsIgnoredBase() needs to respect when platform says include
Summary: accessibilityIsIgnoredBase() needs to respect when platform says include
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-11 11:59 PST by chris fleizach
Modified: 2010-03-12 06:33 PST (History)
5 users (show)

See Also:


Attachments
Patch (13.36 KB, patch)
2010-03-11 12:56 PST, chris fleizach
no flags Details | Formatted Diff | Diff
Patch (14.90 KB, patch)
2010-03-11 13:05 PST, chris fleizach
bdakin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2010-03-11 11:59:27 PST
accessibilityIsIgnoredBase() is not doing this, so when an object is always included by a platform, its not working
Comment 1 chris fleizach 2010-03-11 12:33:54 PST
accessibilityIsIgnoredBased() needs to return a ternary value
Comment 2 chris fleizach 2010-03-11 12:56:04 PST
Created attachment 50532 [details]
Patch
Comment 3 WebKit Review Bot 2010-03-11 13:01:31 PST
Attachment 50532 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/618023
Comment 4 chris fleizach 2010-03-11 13:05:33 PST
Created attachment 50533 [details]
Patch
Comment 5 Beth Dakin 2010-03-11 14:02:50 PST
Comment on attachment 50533 [details]
Patch

> -#if PLATFORM(GTK)
> -    return true;
> -#endif

Are you sure you want to remove this?

r=me
Comment 6 chris fleizach 2010-03-11 14:18:26 PST
(In reply to comment #5)
> (From update of attachment 50533 [details])
> > -#if PLATFORM(GTK)
> > -    return true;
> > -#endif
> 
> Are you sure you want to remove this?
> 
 Yea, i looked at what was going on. GTK wants the platform to decide the fate of that object. Now that that object calls accessibilityIsIgnoredBase(), that's now taken care of

> r=me
Comment 7 chris fleizach 2010-03-11 14:33:41 PST
http://trac.webkit.org/changeset/55855
Comment 8 Gustavo Noronha (kov) 2010-03-12 06:33:16 PST
Thanks for the quick fix! Much appreciated =).