Bug 36024 – Add DOMFormData.idl to expose FormData interface

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Jian Li]

Need to add DOMFormData.idl to expose FormData interface.

[Jian Li]

Created attachment 50521 [details]
Proposed Patch

[Sam Weinig]

Comment on attachment 50521 [details]
Proposed Patch

> +
> +JSValue JSDOMFormData::append(ExecState* exec, const ArgList& args)
> +{
> +    if (args.size() < 2)
> +        return throwError(exec, SyntaxError, "Not enough arguments");

We don't generally throw on too few arguments, but rather let the undefined value get toStringed.

Otherwise, this looks good. r=me if you make that change.

[Csaba Osztrogonác]

Landed in http://trac.webkit.org/changeset/55921, but reverted by http://trac.webkit.org/changeset/55926.

If you apply this patch, Qt build will work. 

diff --git a/WebCore/WebCore.pro b/WebCore/WebCore.pro
index 7d1a56a..80f2e39 100644
--- a/WebCore/WebCore.pro
+++ b/WebCore/WebCore.pro
@@ -289,6 +289,7 @@ SOURCES += \
     bindings/js/JSDebugWrapperSet.cpp \
     bindings/js/JSDocumentCustom.cpp \
     bindings/js/JSDocumentFragmentCustom.cpp \
+    bindings/js/JSDOMFormDataCustom.cpp \
     bindings/js/JSDOMGlobalObject.cpp \
     bindings/js/JSDOMWindowBase.cpp \
     bindings/js/JSDOMWindowCustom.cpp \

---

And please update Qt specific expected file to make buildbot happy:
LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt

-window.FormData [object DOMFormDataConstructor]
-window.FormData.prototype [object DOMFormDataPrototype]
+window.FormData [object FormDataConstructor]
+window.FormData.prototype [object FormDataPrototype]

[Sam Weinig]

Any reason you did not make the change I asked you to make?

[Jian Li]

(In reply to comment #4)
> Any reason you did not make the change I asked you to make?

Sorry, forgot this one. I will make sure this will be applied in next landing.

[Jian Li]

Changed and committed as http://trac.webkit.org/changeset/56003.