Bug 36014 - Combine ctiTrampolines related to different JSValue representation
Summary: Combine ctiTrampolines related to different JSValue representation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-11 07:19 PST by Gabor Loki
Modified: 2010-03-15 09:33 PDT (History)
4 users (show)

See Also:

Attachments
Combine ctiTrampolines on ARM and Thumb-2 (14.82 KB, patch)
2010-03-11 07:19 PST, Gabor Loki 		no flags Details | Formatted Diff | Diff
Combine ctiTrampolines on ARM and Thumb-2 (v2) (14.83 KB, patch)
2010-03-11 07:25 PST, Gabor Loki 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Loki 2010-03-11 07:19:15 PST 
Created attachment 50496 [details]
Combine ctiTrampolines on ARM and Thumb-2

The bug 34939 showed, the copy-paste code and hand coded constants can simply lead to an error. We should try to combine them.

I have created a patch for ARM and Thumb-2. A similar construct can be used for other backends.
Comment 1 Gabor Loki 2010-03-11 07:25:43 PST 
Created attachment 50499 [details]
Combine ctiTrampolines on ARM and Thumb-2 (v2)

Fixed some style issues.
Comment 2 WebKit Review Bot 2010-03-11 07:26:34 PST 
Attachment 50496 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
JavaScriptCore/jit/JITStubs.cpp:593:  Extra space before ( in function call  [whitespace/parens] [4]
JavaScriptCore/jit/JITStubs.cpp:620:  Extra space before ( in function call  [whitespace/parens] [4]
JavaScriptCore/jit/JITStubs.cpp:638:  Extra space before ( in function call  [whitespace/parens] [4]
JavaScriptCore/jit/JITStubs.cpp:656:  Extra space before ( in function call  [whitespace/parens] [4]
JavaScriptCore/jit/JITStubs.cpp:674:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 6 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gavin Barraclough 2010-03-15 00:15:41 PDT 
Comment on attachment 50499 [details]
Combine ctiTrampolines on ARM and Thumb-2 (v2)

Awesome patch Gabor, we have to do this for all archs. Very nice.
Comment 4 WebKit Commit Bot 2010-03-15 09:33:31 PDT 
Comment on attachment 50499 [details]
Combine ctiTrampolines on ARM and Thumb-2 (v2)

Clearing flags on attachment: 50499

Committed r56000: <http://trac.webkit.org/changeset/56000>
Comment 5 WebKit Commit Bot 2010-03-15 09:33:36 PDT 
All reviewed patches have been landed.  Closing bug.