Bug 36014 – Combine ctiTrampolines related to different JSValue representation

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gabor Loki]

Created attachment 50496 [details]
Combine ctiTrampolines on ARM and Thumb-2

The bug 34939 showed, the copy-paste code and hand coded constants can simply lead to an error. We should try to combine them.

I have created a patch for ARM and Thumb-2. A similar construct can be used for other backends.

[Gabor Loki]

Created attachment 50499 [details]
Combine ctiTrampolines on ARM and Thumb-2 (v2)

Fixed some style issues.

[WebKit Review Bot]

Attachment 50496 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
JavaScriptCore/jit/JITStubs.cpp:593:  Extra space before ( in function call  [whitespace/parens] [4]
JavaScriptCore/jit/JITStubs.cpp:620:  Extra space before ( in function call  [whitespace/parens] [4]
JavaScriptCore/jit/JITStubs.cpp:638:  Extra space before ( in function call  [whitespace/parens] [4]
JavaScriptCore/jit/JITStubs.cpp:656:  Extra space before ( in function call  [whitespace/parens] [4]
JavaScriptCore/jit/JITStubs.cpp:674:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 6 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gavin Barraclough]

Comment on attachment 50499 [details]
Combine ctiTrampolines on ARM and Thumb-2 (v2)

Awesome patch Gabor, we have to do this for all archs. Very nice.

[WebKit Commit Bot]

Comment on attachment 50499 [details]
Combine ctiTrampolines on ARM and Thumb-2 (v2)

Clearing flags on attachment: 50499

Committed r56000: <http://trac.webkit.org/changeset/56000>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.