Bug 36012 - Send the frame URL on GeolocationServiceBridgeImpl::startUpdating.
Summary: Send the frame URL on GeolocationServiceBridgeImpl::startUpdating.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-11 06:09 PST by Marcus Bulach
Modified: 2010-03-23 13:09 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.30 KB, patch)
2010-03-11 07:34 PST, Marcus Bulach 		no flags Details | Formatted Diff | Diff
Patch (2.30 KB, patch)
2010-03-11 07:59 PST, Marcus Bulach 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus Bulach 2010-03-11 06:09:19 PST 
Send the frame URL on GeolocationServiceBridgeImpl::startUpdating.
Comment 1 Marcus Bulach 2010-03-11 07:25:24 PST 
This change adds URL when calling GeolocationServiceBridgeImpl::startUpdating so that the embedder can decide whether or not the origin is authorized before actually sending any geoposition.
Comment 2 Marcus Bulach 2010-03-11 07:34:08 PST 
Created attachment 50502 [details]
Patch
Comment 3 Jonathan Dixon 2010-03-11 07:47:29 PST 
Comment on attachment 50502 [details]
Patch

> Index: WebKit/chromium/public/GeolocationServiceBridgeChromium.h
> ===================================================================
> --- WebKit/chromium/public/GeolocationServiceBridgeChromium.h	(revision 55784)
> +++ WebKit/chromium/public/GeolocationServiceBridgeChromium.h	(working copy)
> @@ -53,7 +53,7 @@ public:
>  class WebGeolocationServiceInterface {
>  public:
>      virtual void requestPermissionForFrame(int bridgeId, const WebURL& url) = 0;
> -    virtual void startUpdating(int bridgeId, bool hasHighAccuracy) = 0;
> +    virtual void startUpdating(int bridgeId, const WebURL& url, bool hasHighAccuracy) = 0;

Nit: I'm not sure if there's a webkit convention on this, but wantsHighAccuracy would be closer to the intending meaning than hasHighAccuracy
Comment 4 Marcus Bulach 2010-03-11 07:59:59 PST 
Created attachment 50505 [details]
Patch
Comment 5 Jeremy Orlow 2010-03-11 08:01:15 PST 
Comment on attachment 50505 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2010-03-15 13:30:25 PDT 
Comment on attachment 50505 [details]
Patch

Clearing flags on attachment: 50505

Committed r56011: <http://trac.webkit.org/changeset/56011>
Comment 7 WebKit Commit Bot 2010-03-15 13:30:30 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Darin Fisher (:fishd, Google) 2010-03-23 13:09:39 PDT 
Comment on attachment 50505 [details]
Patch

> Index: WebKit/chromium/src/GeolocationServiceBridgeChromium.cpp
...
> +    getWebViewClient()->getGeolocationService()->startUpdating(m_bridgeId, m_GeolocationServiceChromium->frame()->document()->url(), positionOptions->enableHighAccuracy());

please note that the WebViewClient can be null!