Bug 36011 - Add TextEncoding::usesBackslashAsCurrencySymbol()
Summary: Add TextEncoding::usesBackslashAsCurrencySymbol()
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 24906
  Show dependency treegraph
 
Reported: 2010-03-11 05:12 PST by Shinichiro Hamaji
Modified: 2010-03-15 00:31 PDT (History)
0 users

See Also:


Attachments
Patch v1 (1.80 KB, patch)
2010-03-11 05:14 PST, Shinichiro Hamaji
darin: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2010-03-11 05:12:08 PST
This function will be used by Bug 24906 to implement transcoding based on both fonts and encodings.
Comment 1 Shinichiro Hamaji 2010-03-11 05:14:13 PST
Created attachment 50488 [details]
Patch v1
Comment 2 Darin Adler 2010-03-12 09:17:07 PST
Comment on attachment 50488 [details]
Patch v1

The logic here is backwards. This changes some "==" to "!=".

As a side note, I also personally don’t think this refactoring is an improvement. The old code seems clearer to me.
Comment 3 Shinichiro Hamaji 2010-03-15 00:31:08 PDT
> The logic here is backwards. This changes some "==" to "!=".

Oops. Sorry for the mistake...

> As a side note, I also personally don’t think this refactoring is an
> improvement. The old code seems clearer to me.

I see. So, I think I will make backslashAsCurrencySymbol() public when I will use. Making this issue WONTFIX...