Bug 36007 - [GStreamer] progressTimer never stopped after EOS
Summary: [GStreamer] progressTimer never stopped after EOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-11 03:13 PST by Philippe Normand
Modified: 2010-03-15 01:20 PDT (History)
0 users

See Also:


Attachments
don't mark the pipeline as paused on EOS (2.18 KB, patch)
2010-03-11 05:19 PST, Philippe Normand
gustavo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2010-03-11 03:13:03 PST
The HTMLMediaElement progressTimer is not stopped after media playback ended. I think this is because we pause the pipeline in our didEnd() method, so the media element thinks the playback is paused, the timer never gets a chance to stop.
Comment 1 Philippe Normand 2010-03-11 03:14:28 PST
It is easy to check with the launcher, activate Media logging with WEBKIT_DEBUG, watch a HTML5 video on youtube, wait the end and observe the progress timer still running, forever.
Comment 2 Philippe Normand 2010-03-11 05:19:34 PST
Created attachment 50489 [details]
don't mark the pipeline as paused on EOS
Comment 3 Gustavo Noronha (kov) 2010-03-11 14:39:55 PST
Comment on attachment 50489 [details]
don't mark the pipeline as paused on EOS

Hrm. How about we enable the play/pause test somehow? That would rock =(. Sounds good to me for now, though.
Comment 4 Philippe Normand 2010-03-15 01:20:27 PDT
Landed in r55987.