Bug 36002 – Enhance Windows DRT implementation to support platform scroll wheel events.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Andy Estes]

DRT layout tests gained the ability to simulate mouse scroll wheel events in http://trac.webkit.org/changeset/55739.  Currently this is only supported on Mac OS 10.5 and 10.6.  The Windows DRT implementation should be enhanced to dispatch scroll wheel events, and layout tests that utilize this functionality should be removed from the Skipped file.

[Per Arne Vollan]

Created attachment 282770 [details]
Patch

[Brent Fulgham]

Comment on attachment 282770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282770&action=review

These changes look good. I feel like the 'continuousMouseScrollBy' is just the first step in actually supporting that behavior, so I'm not being too picky about how it works at the moment.

> Tools/DumpRenderTree/win/EventSender.cpp:818
> +    double deltaX = JSValueToNumber(context, arguments[0], exception);

Whoops! I wonder if that caused any crashes ....

> Tools/DumpRenderTree/win/EventSender.cpp:850
> +}

I don't understand what makes 'continuousMouseScrollBy' different than just the regular 'mouseScrollBy'. Maybe that's why the tests are still failing after this change?

[Per Arne Vollan]

(In reply to comment #2)
> Comment on attachment 282770 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282770&action=review
> 
> These changes look good. I feel like the 'continuousMouseScrollBy' is just
> the first step in actually supporting that behavior, so I'm not being too
> picky about how it works at the moment.
> 
> > Tools/DumpRenderTree/win/EventSender.cpp:818
> > +    double deltaX = JSValueToNumber(context, arguments[0], exception);
> 
> Whoops! I wonder if that caused any crashes ....
> 
> > Tools/DumpRenderTree/win/EventSender.cpp:850
> > +}
> 
> I don't understand what makes 'continuousMouseScrollBy' different than just
> the regular 'mouseScrollBy'. Maybe that's why the tests are still failing
> after this change?

Thanks for reviewing!

I think the scroll unit is pixels in 'continuousMouseScrollBy', while it is lines in 'mouseScrollBy'.

[Per Arne Vollan]

Committed r202849: <https://trac.webkit.org/changeset/202849>