Bug 36002 - Enhance Windows DRT implementation to support platform scroll wheel events.
: Enhance Windows DRT implementation to support platform scroll wheel events.
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Tools / Tests
: 528+ (Nightly build)
: PC Windows XP
: P2 Enhancement
Assigned To: Per Arne Vollan
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-03-10 21:55 PST by Andy Estes
Modified: 2016-07-05 23:16 PDT (History)
3 users (show)

See Also:


Attachments
Patch (7.56 KB, patch)
2016-07-05 05:05 PDT, Per Arne Vollan
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2010-03-10 21:55:40 PST
DRT layout tests gained the ability to simulate mouse scroll wheel events in http://trac.webkit.org/changeset/55739.  Currently this is only supported on Mac OS 10.5 and 10.6.  The Windows DRT implementation should be enhanced to dispatch scroll wheel events, and layout tests that utilize this functionality should be removed from the Skipped file.
Comment 1 Per Arne Vollan 2016-07-05 05:05:55 PDT
Created attachment 282770 [details]
Patch
Comment 2 Brent Fulgham 2016-07-05 08:20:39 PDT
Comment on attachment 282770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282770&action=review

These changes look good. I feel like the 'continuousMouseScrollBy' is just the first step in actually supporting that behavior, so I'm not being too picky about how it works at the moment.

> Tools/DumpRenderTree/win/EventSender.cpp:818
> +    double deltaX = JSValueToNumber(context, arguments[0], exception);

Whoops! I wonder if that caused any crashes ....

> Tools/DumpRenderTree/win/EventSender.cpp:850
> +}

I don't understand what makes 'continuousMouseScrollBy' different than just the regular 'mouseScrollBy'. Maybe that's why the tests are still failing after this change?
Comment 3 Per Arne Vollan 2016-07-05 09:00:45 PDT
(In reply to comment #2)
> Comment on attachment 282770 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282770&action=review
> 
> These changes look good. I feel like the 'continuousMouseScrollBy' is just
> the first step in actually supporting that behavior, so I'm not being too
> picky about how it works at the moment.
> 
> > Tools/DumpRenderTree/win/EventSender.cpp:818
> > +    double deltaX = JSValueToNumber(context, arguments[0], exception);
> 
> Whoops! I wonder if that caused any crashes ....
> 
> > Tools/DumpRenderTree/win/EventSender.cpp:850
> > +}
> 
> I don't understand what makes 'continuousMouseScrollBy' different than just
> the regular 'mouseScrollBy'. Maybe that's why the tests are still failing
> after this change?

Thanks for reviewing!

I think the scroll unit is pixels in 'continuousMouseScrollBy', while it is lines in 'mouseScrollBy'.
Comment 4 Per Arne Vollan 2016-07-05 23:16:35 PDT
Committed r202849: <https://trac.webkit.org/changeset/202849>