WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
36001
SQLiteFileSystem::ensureDatabaseFileExists() doesn't do what it supposed to do.
https://bugs.webkit.org/show_bug.cgi?id=36001
Summary
SQLiteFileSystem::ensureDatabaseFileExists() doesn't do what it supposed to do.
Lyon Chen
Reported
2010-03-10 21:11:06 PST
For SQLiteFileSystem::ensureDatabaseFileExists(const String& fileName, bool checkPathOnly), the second parameter is checkPathOnly and it means check path only when it's true, but the only place it's called is DatabaseTracker::openTrackerDatabase(), which calls ensureDatabaseFileExists() with parameter createIfDoesNotExist and it expect the file will be created if it doesn't existed already. I think SQLiteFileSystem::ensureDatabaseFileExists() should be changed to do as its function name indicates, create the file if it's not existed already.
Attachments
Add attachment
proposed patch, testcase, etc.
Lyon Chen
Comment 1
2010-03-11 07:48:35 PST
My bad, it's not a bug.
Yong Li
Comment 2
2010-03-11 09:33:58 PST
close it
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug