RESOLVED FIXED 35990
[Chromium] Popup font size needs to be exposed to clients. 
https://bugs.webkit.org/show_bug.cgi?id=35990
Summary [Chromium] Popup font size needs to be exposed to clients.
Scott Byer
Reported 2010-03-10 15:26:12 PST
In the case where a WebKit client wants to implement a combobox/popup elsewhere, the font size needs to be exposed so that the popped up menu can match the font size being used on the page at the current zoom. See http://crbug.com/14010 I am working on this bug (scottbyer@chromium.org)
Attachments
Proposed patch. (2.97 KB, patch)
2010-03-10 16:29 PST, Scott Byer 		no flags
DetailsFormatted DiffDiff
Proposed patch (style fixed). (2.99 KB, patch)
2010-03-10 16:35 PST, Scott Byer 		fishd: review+
fishd: commit-queue-
DetailsFormatted DiffDiff
Proposed patch (with spelling fixed). (2.99 KB, patch)
2010-03-10 20:52 PST, Scott Byer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Scott Byer
Comment 1 2010-03-10 16:29:24 PST
Created attachment 50453 [details] Proposed patch.
WebKit Review Bot
Comment 2 2010-03-10 16:33:43 PST
Attachment 50453 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 ChangeLog:8: Line contains tab character. [whitespace/tab] [5] ChangeLog:9: Line contains tab character. [whitespace/tab] [5] ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Scott Byer
Comment 3 2010-03-10 16:35:41 PST
Created attachment 50455 [details] Proposed patch (style fixed).
Darin Fisher (:fishd, Google)
Comment 4 2010-03-10 19:50:21 PST
Comment on attachment 50455 [details] Proposed patch (style fixed). > Index: ChangeLog ... > + WebPopupMenuInfo that recieves that information to convey that to nit: s/recieves/receives/ otherwise, r=me post a revised patch, and then i'll mark it cq+ so it'll get committed. thanks!
Scott Byer
Comment 5 2010-03-10 20:52:57 PST
Created attachment 50468 [details] Proposed patch (with spelling fixed).
WebKit Commit Bot
Comment 6 2010-03-12 07:11:00 PST
Comment on attachment 50468 [details] Proposed patch (with spelling fixed). Clearing flags on attachment: 50468 Committed r55897: <http://trac.webkit.org/changeset/55897>
WebKit Commit Bot
Comment 7 2010-03-12 07:11:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.