Bug 35976 – On Window, dwItemData from a custom context menu item cannot be retrieved when that item is selected.

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Ada Chan]

A WebKit client can add a custom context menu item to the context menu via the IWebUIDelegate::contextMenuItemsForElement().  That custom context menu item (the MENUITEMINFO object) can have a non-null dwItemData.  If that context menu item is selected, IWebUIDelegate::contextMenuItemSelected() is called, but the MENUITEMINFO no longer has the dwItemData.  That's because in contextMenuItemByIdOrPosition() in ContextMenuWin.cpp, we didn't specify MIIM_DATA in the fMask when copying over the menu item information.

[Ada Chan]

Created attachment 50413 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 50413 [details]
Patch

> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 55785)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,13 @@
> [phone]  Ada Chan  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=35976
> +
> +        Retrieve any dwItemData that's set on the context menu item in contextMenuItemByIdOrPosition().

I think you should mention that this is useful for WebKit clients who store data in this member for their custom menu items.

r=me

-Adam

[Ada Chan]

Fixed in r55787.