Bug 35971 - Web Inspector: Implement a progress indicator in the Audits panel when checks are running
Summary: Web Inspector: Implement a progress indicator in the Audits panel when checks...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-10 07:44 PST by Alexander Pavlov (apavlov)
Modified: 2010-03-15 09:25 PDT (History)
7 users (show)

See Also:


Attachments
[PATCH] Suggested solution (8.19 KB, patch)
2010-03-12 03:18 PST, Alexander Pavlov (apavlov)
no flags Details | Formatted Diff | Diff
[IMAGE] Resource loading progress reported in the button caption (38.98 KB, image/png)
2010-03-12 03:23 PST, Alexander Pavlov (apavlov)
no flags Details
Spinner (1.64 KB, image/gif)
2010-03-12 05:55 PST, Timothy Hatcher
no flags Details
[PATCH] Separated progress message, added spinner (14.15 KB, patch)
2010-03-12 10:18 PST, Alexander Pavlov (apavlov)
timothy: review-
Details | Formatted Diff | Diff
[IMAGE] Standalone message with spinner at "vertical-align: middle" (42.05 KB, image/png)
2010-03-15 07:42 PDT, Alexander Pavlov (apavlov)
no flags Details
[IMAGE] Message with spinner at "vertical-align: text-top" (39.11 KB, image/png)
2010-03-15 08:06 PDT, Alexander Pavlov (apavlov)
no flags Details
[PATCH] Comments addressed, "vertical-align: text-top" (14.29 KB, patch)
2010-03-15 08:12 PDT, Alexander Pavlov (apavlov)
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2010-03-10 07:44:48 PST
When audits are running (with/without page refresh), there is no way for a user to know if something is happening or not in the Web Inspector.
Comment 1 Alexander Pavlov (apavlov) 2010-03-12 03:18:37 PST
Created attachment 50584 [details]
[PATCH] Suggested solution

Only resource loading progress is needed, audits run nearly instantly.
Comment 2 Alexander Pavlov (apavlov) 2010-03-12 03:23:11 PST
Created attachment 50585 [details]
[IMAGE] Resource loading progress reported in the button caption
Comment 3 Timothy Hatcher 2010-03-12 05:34:29 PST
I don't think turning thr button into a progress indicator is great.

A spinner with status text next to it would be better. But having it be a button is confusing, what happens if you press it?
Comment 4 Timothy Hatcher 2010-03-12 05:55:37 PST
Created attachment 50590 [details]
Spinner
Comment 5 Alexander Pavlov (apavlov) 2010-03-12 10:18:04 PST
Created attachment 50607 [details]
[PATCH] Separated progress message, added spinner
Comment 6 Timothy Hatcher 2010-03-12 10:26:34 PST
Comment on attachment 50607 [details]
[PATCH] Separated progress message, added spinner

> +        this.totalResources = 1;

Why 1 not 0?

> +        this.totalResources++;

Should be ++this.totalResources;

> +        this.loadedResources++;

Ditto.


> +            this._resourceProgressTextElement.textContent = WebInspector.UIString("Loading, completed %d of %d items", this.loadedResources, this.totalResources);

I think "Loading (%d of %d)" is just as clear and shorter.

> +    vertical-align: sub;

I would expect middle, I never heard of sub until now. What does sub do? Does middle give the same result?

Looks good. Will r+ if you fix these things.
Comment 7 Alexander Pavlov (apavlov) 2010-03-15 07:42:50 PDT
Created attachment 50701 [details]
[IMAGE] Standalone message with spinner at "vertical-align: middle"
Comment 8 Alexander Pavlov (apavlov) 2010-03-15 08:06:56 PDT
Created attachment 50706 [details]
[IMAGE] Message with spinner at "vertical-align: text-top"
Comment 9 Alexander Pavlov (apavlov) 2010-03-15 08:12:25 PDT
Created attachment 50707 [details]
[PATCH] Comments addressed, "vertical-align: text-top"
Comment 10 Alexander Pavlov (apavlov) 2010-03-15 08:13:45 PDT
(In reply to comment #6)
> (From update of attachment 50607 [details])
> > +        this.totalResources = 1;
> 
> Why 1 not 0?

Comment added

> > +        this.totalResources++;
> 
> Should be ++this.totalResources;

Done

> > +        this.loadedResources++;
> 
> Ditto.

Done

> 
> > +            this._resourceProgressTextElement.textContent = WebInspector.UIString("Loading, completed %d of %d items", this.loadedResources, this.totalResources);
> 
> I think "Loading (%d of %d)" is just as clear and shorter.

This was borrowed from the Safari page loading status. Done

> 
> > +    vertical-align: sub;
> 
> I would expect middle, I never heard of sub until now. What does sub do? Does
> middle give the same result?

No, using "text-top" instead.
Comment 11 Alexander Pavlov (apavlov) 2010-03-15 09:25:34 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       WebCore/ChangeLog
        M       WebCore/English.lproj/localizedStrings.js
        M       WebCore/GNUmakefile.am
        M       WebCore/WebCore.gypi
        M       WebCore/inspector/front-end/AuditLauncherView.js
        M       WebCore/inspector/front-end/AuditsPanel.js
        A       WebCore/inspector/front-end/Images/spinner.gif
        M       WebCore/inspector/front-end/WebKit.qrc
        M       WebCore/inspector/front-end/audits.css
        M       WebCore/inspector/front-end/inspector.js
Committed r55999