Bug 35967 - Remove extra <new> include and add guards to operator new/delete definitions
Summary: Remove extra <new> include and add guards to operator new/delete definitions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-10 04:17 PST by Zoltan Horvath
Modified: 2010-03-16 09:20 PDT (History)
0 users

See Also:


Attachments
proposed patch (1.67 KB, patch)
2010-03-10 04:19 PST, Zoltan Horvath
no flags Details | Formatted Diff | Diff
Patch (1.66 KB, patch)
2010-03-16 00:51 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2010-03-10 04:17:24 PST
Remove extra <new> header include from FastAlloc.cpp since it is included in FastAlloc.h. 

Add ENABLE_GLOBAL_FASTMALLOC_NEW macro guard to operator new/delete/new []/delete [] definitions.
Comment 1 Zoltan Horvath 2010-03-10 04:19:30 PST
Created attachment 50392 [details]
proposed patch
Comment 2 Laszlo Gombos 2010-03-12 06:57:45 PST
Comment on attachment 50392 [details]
proposed patch

> +#if defined(ENABLE_GLOBAL_FASTMALLOC_NEW)

Should this be the following instead ? 

+#if ENABLE(GLOBAL_FASTMALLOC_NEW)
Comment 3 Eric Seidel (no email) 2010-03-15 15:24:14 PDT
Comment on attachment 50392 [details]
proposed patch

Should use the ENABLE macros.
Comment 4 Zoltan Horvath 2010-03-16 00:51:22 PDT
Created attachment 50773 [details]
Patch
Comment 5 Zoltan Horvath 2010-03-16 09:20:09 PDT
Comment on attachment 50773 [details]
Patch

Clearing flags on attachment: 50773

Committed r56066: <http://trac.webkit.org/changeset/56066>
Comment 6 Zoltan Horvath 2010-03-16 09:20:17 PDT
All reviewed patches have been landed.  Closing bug.