WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 35967
Remove extra <new> include and add guards to operator new/delete definitions
https://bugs.webkit.org/show_bug.cgi?id=35967
Summary
Remove extra <new> include and add guards to operator new/delete definitions
Zoltan Horvath
Reported
2010-03-10 04:17:24 PST
Remove extra <new> header include from FastAlloc.cpp since it is included in FastAlloc.h. Add ENABLE_GLOBAL_FASTMALLOC_NEW macro guard to operator new/delete/new []/delete [] definitions.
Attachments
proposed patch
(1.67 KB, patch)
2010-03-10 04:19 PST
,
Zoltan Horvath
no flags
Details
Formatted Diff
Diff
Patch
(1.66 KB, patch)
2010-03-16 00:51 PDT
,
Zoltan Horvath
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Zoltan Horvath
Comment 1
2010-03-10 04:19:30 PST
Created
attachment 50392
[details]
proposed patch
Laszlo Gombos
Comment 2
2010-03-12 06:57:45 PST
Comment on
attachment 50392
[details]
proposed patch
> +#if defined(ENABLE_GLOBAL_FASTMALLOC_NEW)
Should this be the following instead ? +#if ENABLE(GLOBAL_FASTMALLOC_NEW)
Eric Seidel (no email)
Comment 3
2010-03-15 15:24:14 PDT
Comment on
attachment 50392
[details]
proposed patch Should use the ENABLE macros.
Zoltan Horvath
Comment 4
2010-03-16 00:51:22 PDT
Created
attachment 50773
[details]
Patch
Zoltan Horvath
Comment 5
2010-03-16 09:20:09 PDT
Comment on
attachment 50773
[details]
Patch Clearing flags on attachment: 50773 Committed
r56066
: <
http://trac.webkit.org/changeset/56066
>
Zoltan Horvath
Comment 6
2010-03-16 09:20:17 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug