Bug 35966 – Web Inspector: GraphBar elements at the bottom of Timeline are not visible.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Ilya Tikhonovsky]

In case of long recording interval the latest GraphBar elements are not visible at all if they are small.

[Timothy Hatcher]

Under the scrollbal?

[Ilya Tikhonovsky]

Created attachment 50389 [details]
[Patch] The fix for GraphBar's position.

[Ilya Tikhonovsky]

Created attachment 50391 [details]
Old screen shot with incorrect position of GraphBars.

[Ilya Tikhonovsky]

(In reply to comment #1)
> Under the scrollbal?

Yep. Usually the last elements were hidden by scroll bar.
But the real reason of that was misspositioning because we are using expandOffset which for collapsing groups of elements, minimum width of the bars and the bar border size.

[WebKit Commit Bot]

Comment on attachment 50389 [details]
[Patch] The fix for GraphBar's position.

Rejecting patch 50389 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Timothy Hatcher', '--force']" exit_code: 2
patching file WebCore/ChangeLog
patch: **** malformed patch at line 18:          Unreviewed build fix. Fix variable name change that somehow didn't

patching file WebCore/inspector/front-end/TimelinePanel.js
Hunk #1 succeeded at 570 (offset -2 lines).

Full output: http://webkit-commit-queue.appspot.com/results/602028

[Ilya Tikhonovsky]

Created attachment 50654 [details]
[Patch] The same patch but rebaselined. The fix fir Graph Bar's position.

[WebKit Commit Bot]

Comment on attachment 50654 [details]
[Patch] The same patch but rebaselined. The fix fir Graph Bar's position.

Rejecting patch 50654 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 12482 test cases.
fast/loader/api-test-new-window-data-load-base-url.html -> failed

Exiting early after 1 failures. 7684 tests run.
128.69s total testing time

7683 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
3 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/731012

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/TimelinePanel.js
Committed r55991

[Eric Seidel (no email)]

I'm guessing this was bug 35594.

[Ilya Tikhonovsky]

This change-list just change absolute positions of bar elements in the Timeline view of Web Inspector when WebInspector is opened and Timeline is recorded.

I think fast/loader/api-test-new-window-data-load-base-url.html test just flaky.
This test passed successfully when the patch was landed manually.

[Eric Seidel (no email)]

Yes.  Definitely appears to be flakey.  You should feel encouraged to file bugs and simply re-queue (by marking cq+ again) if/when the commit-queue ever hits a flakey test.