Bug 35956 - [Chromium] Have a grd file live upstream for resources that we pull from WebKit/WebCore
Summary: [Chromium] Have a grd file live upstream for resources that we pull from WebK...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-10 00:13 PST by Tony Chang
Modified: 2010-03-10 00:41 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.46 KB, patch)
2010-03-10 00:16 PST, Tony Chang
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-03-10 00:13:51 PST
We should have a grd file in WebKit/chromium/ for resources that live upstream.  This has a couple of advantages:

- If a resource we depend on upstream moves, whoever moves the file can fix the chromium build by updating the grd file.
- As part of the chromium DRT work, we need to be able to build webkit_resources.grd upstream.  The references to third_party files won't resolve upstream, so this allows us to get rid of the third_party references.

Patch coming with a small grd file.

The Chromium side patch that will start using this file is here:
http://codereview.chromium.org/792005
Comment 1 Tony Chang 2010-03-10 00:16:13 PST
Created attachment 50375 [details]
Patch
Comment 2 Tony Chang 2010-03-10 00:17:53 PST
(In reply to comment #1)
> Created an attachment (id=50375) [details]
> Patch

I am open to suggestions on where to put the file (e.g., the WebKit/win port has a .rc file in WebKit/win/WebKit.vcproj/) and on what to name the grd file.  Right now they are all dev tool resources, but you could imagine us wanting to include other resources here (like the missing image png).
Comment 3 Tony Chang 2010-03-10 00:28:28 PST
Comment on attachment 50375 [details]
Patch

Based on offline discussion, I'm going to give this a more general filename so we can add other resources (not devtool related) to it in the future.
Comment 4 Tony Chang 2010-03-10 00:41:37 PST
Committed r55769: <http://trac.webkit.org/changeset/55769>