RESOLVED FIXED 35950
[chromium] Screen coordinate flipping in Chromium Mac event conversion should use primary monitor 
https://bugs.webkit.org/show_bug.cgi?id=35950
Summary [chromium] Screen coordinate flipping in Chromium Mac event conversion should...
Stuart Morgan
Reported 2010-03-09 16:29:25 PST
Screen-coordinate flipping should be based on the primary monitor (the one with the menu bar), but currently the Chromium event factory code is using the screen that the window is on. This has mostly worked out before because we have the same bug in the window frame conversion: http://codereview.chromium.org/751002 I'll coordinate with the WebKit gardner to get both patches in at the same time.
Attachments
Fix (3.74 KB, patch)
2010-03-09 16:43 PST, Stuart Morgan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stuart Morgan
Comment 1 2010-03-09 16:43:27 PST
Created attachment 50360 [details] Fix Fixes the bug, and eliminates the duplicate location conversion code between mouse events and mouse wheel events. Also fixes the way the global coordinates are calculated so that it actually uses the passed event, rather than the current location of the mouse.
Darin Fisher (:fishd, Google)
Comment 2 2010-03-09 22:28:59 PST
Comment on attachment 50360 [details] Fix Since this is a dual-sided patch, I'm assuming you need to coordinate this landing with the appropriate webkit gardener.
Nate Chapin
Comment 3 2010-03-10 11:18:42 PST
Comment on attachment 50360 [details] Fix I'm the appropriate chromium webkit gardener, and I think this is a good time for this patch, so switching to cq+
WebKit Commit Bot
Comment 4 2010-03-11 19:04:45 PST
Comment on attachment 50360 [details] Fix Clearing flags on attachment: 50360 Committed r55877: <http://trac.webkit.org/changeset/55877>
WebKit Commit Bot
Comment 5 2010-03-11 19:04:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.