Bug 35950 - [chromium] Screen coordinate flipping in Chromium Mac event conversion should use primary monitor
Summary: [chromium] Screen coordinate flipping in Chromium Mac event conversion should...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Stuart Morgan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-09 16:29 PST by Stuart Morgan
Modified: 2010-03-11 19:04 PST (History)
2 users (show)

See Also:


Attachments
Fix (3.74 KB, patch)
2010-03-09 16:43 PST, Stuart Morgan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stuart Morgan 2010-03-09 16:29:25 PST
Screen-coordinate flipping should be based on the primary monitor (the one with the menu bar), but currently the Chromium event factory code is using the screen that the window is on.

This has mostly worked out before because we have the same bug in the window frame conversion: http://codereview.chromium.org/751002
I'll coordinate with the WebKit gardner to get both patches in at the same time.
Comment 1 Stuart Morgan 2010-03-09 16:43:27 PST
Created attachment 50360 [details]
Fix

Fixes the bug, and eliminates the duplicate location conversion code between mouse events and mouse wheel events. Also fixes the way the global coordinates are calculated so that it actually uses the passed event, rather than the current location of the mouse.
Comment 2 Darin Fisher (:fishd, Google) 2010-03-09 22:28:59 PST
Comment on attachment 50360 [details]
Fix

Since this is a dual-sided patch, I'm assuming you need to
coordinate this landing with the appropriate webkit gardener.
Comment 3 Nate Chapin 2010-03-10 11:18:42 PST
Comment on attachment 50360 [details]
Fix

I'm the appropriate chromium webkit gardener, and I think this is a good time for this patch, so switching to cq+
Comment 4 WebKit Commit Bot 2010-03-11 19:04:45 PST
Comment on attachment 50360 [details]
Fix

Clearing flags on attachment: 50360

Committed r55877: <http://trac.webkit.org/changeset/55877>
Comment 5 WebKit Commit Bot 2010-03-11 19:04:49 PST
All reviewed patches have been landed.  Closing bug.