Bug 35946 - [chromium] Fix memory leak in WebImageDecoder API
Summary: [chromium] Fix memory leak in WebImageDecoder API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-09 15:04 PST by Kavita Kanetkar
Modified: 2010-03-12 08:36 PST (History)
5 users (show)

See Also:


Attachments
proposed fix (3.64 KB, patch)
2010-03-09 15:18 PST, Kavita Kanetkar
fishd: review-
kkanetkar: commit-queue-
Details | Formatted Diff | Diff
patch2 (2.67 KB, patch)
2010-03-11 14:01 PST, Kavita Kanetkar
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kavita Kanetkar 2010-03-09 15:04:01 PST
Fix  getFrameAtIndex() that causes leak in WebImage.
Comment 1 Kavita Kanetkar 2010-03-09 15:18:38 PST
Created attachment 50356 [details]
proposed fix

2-sided fix. Needs a downstream fix as well.
Comment 2 Darin Fisher (:fishd, Google) 2010-03-09 16:04:00 PST
Comment on attachment 50356 [details]
proposed fix

r- for reasons discussed in person.  (sorry folks if you are following at home, you'll just have to guess)
Comment 3 Dimitri Glazkov (Google) 2010-03-09 16:30:43 PST
Was it the peanut butter?
Comment 4 Kavita Kanetkar 2010-03-11 14:01:29 PST
Created attachment 50535 [details]
patch2

Thanks Darin, for the comments.
Comment 5 WebKit Commit Bot 2010-03-12 08:36:47 PST
Comment on attachment 50535 [details]
patch2

Clearing flags on attachment: 50535

Committed r55906: <http://trac.webkit.org/changeset/55906>
Comment 6 WebKit Commit Bot 2010-03-12 08:36:52 PST
All reviewed patches have been landed.  Closing bug.