Bug 35922 - [GTK] testkeyevents doesn't stop if input event injection fails
Summary: [GTK] testkeyevents doesn't stop if input event injection fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-09 07:42 PST by Philippe Normand
Modified: 2010-03-10 00:07 PST (History)
1 user (show)

See Also:

Attachments
proposed patch (1.73 KB, patch)
2010-03-09 07:44 PST, Philippe Normand 		gustavo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2010-03-09 07:42:55 PST 
In that test we call gtk_test_widget_send_key() but don't check the return value. If for some reason the event injection failed, the main loop of the test fixture is never stopped.
Comment 1 Philippe Normand 2010-03-09 07:44:33 PST 
Created attachment 50306 [details]
proposed patch
Comment 2 Gustavo Noronha (kov) 2010-03-09 09:12:33 PST 
Comment on attachment 50306 [details]
proposed patch

Very good. Let's try to get Martin to look at this problem.
Comment 3 Philippe Normand 2010-03-10 00:07:20 PST 
Landed in r55768