RESOLVED FIXED 35911
Baby steps towards IndexedDB: Start implementing callbacks. 
https://bugs.webkit.org/show_bug.cgi?id=35911
Summary Baby steps towards IndexedDB: Start implementing callbacks.
Jeremy Orlow
Reported 2010-03-09 04:47:13 PST
This patch adds some infastructure for IndexedDB callbacks in V8. It also adds a stub of IDBDatabaseRequest. In the near future, I'll gut the event based implementation code, flesh out IDBReqest further, and start plumbing IndexedDatabaseRequest. Code is not testible because it doesn't work (yet).
Attachments
patch (14.57 KB, patch)
2010-03-09 04:51 PST, Jeremy Orlow 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2010-03-09 04:51:45 PST
Created attachment 50294 [details] patch
WebKit Review Bot
Comment 2 2010-03-09 04:56:00 PST
Attachment 50294 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/bindings/v8/custom/V8CustomIDBCallback.h:92: One space before end of line comments [whitespace/comments] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dimitri Glazkov (Google)
Comment 3 2010-03-09 13:51:05 PST
Comment on attachment 50294 [details] patch > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > index 92d76a9..9e2ecc4 100644 > --- a/WebCore/ChangeLog > +++ b/WebCore/ChangeLog > @@ -1,3 +1,33 @@ > +2010-03-09 Jeremy Orlow <jorlow@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Baby steps towards IndexedDB: Start implementing callbacks. > + Need a short description and bug URL (OOPS!) Oops indeed. ok otherwise.
Note You need to log in before you can comment on or make changes to this bug.