Bug 35909 - [GTK] GTK_WIDGET_IS_SENSITIVE is deprecated in GTK+ 2.20
Summary: [GTK] GTK_WIDGET_IS_SENSITIVE is deprecated in GTK+ 2.20
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-09 03:24 PST by Philippe Normand
Modified: 2010-03-15 01:36 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch (1.59 KB, patch)
2010-03-09 03:29 PST, Philippe Normand 		zecke: review-
Details | Formatted Diff | Diff
updated patch (1.66 KB, patch)
2010-03-10 00:10 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
updated patch (1.66 KB, patch)
2010-03-10 00:11 PST, Philippe Normand 		zecke: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2010-03-09 03:24:26 PST 
We should use gtk_widget_is_sensitive() instead if GTK version is >= 2.18.
Comment 1 Philippe Normand 2010-03-09 03:29:03 PST 
Created attachment 50287 [details]
proposed patch
Comment 2 Holger Freyther 2010-03-09 20:22:12 PST 
Comment on attachment 50287 [details]
proposed patch

I might miss my morning coffee... or people from shelbyville has put stuff into the water...


> +        [GTK] GTK_WIDGET_IS_SENSITIVE deprecated in GTK+ 2.20

please put a verb like "is" there to make it a sentence. :)


> +
> +#if GTK_CHECK_VERSION(2, 18, 0)
>      if (GTK_WIDGET_IS_SENSITIVE(widget)) {
> +#else
> +    if (GTK_WIDGET_IS_SENSITIVE(widget)) {
> +#endif

this looks identical. I think you want to make one of them gtk_widget_is_sensitive?
Comment 3 Philippe Normand 2010-03-10 00:10:31 PST 
Created attachment 50372 [details]
updated patch
Comment 4 Philippe Normand 2010-03-10 00:11:25 PST 
Created attachment 50373 [details]
updated patch
Comment 5 WebKit Review Bot 2010-03-10 00:13:27 PST 
Attachment 50372 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/579005
Comment 6 Philippe Normand 2010-03-15 01:36:08 PDT 
Landed in r55989.