Bug 35907 – Allow custom memory allocation control for AtomicString class

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Zoltan Horvath]

Inherits the following class from FastAllocBase because it is instantiated by 'new':

class name   - instantiated at: WebCore/'location'
AtomicString - WebCore/html/HTMLTableElement.cpp:525

[Zoltan Horvath]

Created attachment 50281 [details]
proposed patch

[Eric Seidel (no email)]

Comment on attachment 50281 [details]
proposed patch

There was concern expressed before that these were making classes bigger?  Was that issue ever resolved?  Otherwise this change looks fine.

[Eric Seidel (no email)]

Attachment 50281 [details] was posted by a committer and has review+, assigning to Zoltan Horvath for commit.

[Zoltan Horvath]

Comment on attachment 50281 [details]
proposed patch

Clearing flags on attachment: 50281

Committed r56100: <http://trac.webkit.org/changeset/56100>

[Zoltan Horvath]

All reviewed patches have been landed.  Closing bug.

[Zoltan Horvath]

(In reply to comment #2)
> There was concern expressed before that these were making classes bigger?  Was
> that issue ever resolved?  Otherwise this change looks fine.

I opened a bug for it (bug #33896) and made a static analysis on the classes.

[Darin Adler]

(In reply to comment #6)
> (In reply to comment #2)
> > There was concern expressed before that these were making classes bigger?  Was
> > that issue ever resolved?  Otherwise this change looks fine.
> 
> I opened a bug for it (bug #33896) and made a static analysis on the classes.

I'm not sure what the status is, though. If additional introduction of these changes are making our classes still bigger maybe we should hold off until we decide if that's OK.