Bug 35880 - fast/events/touch/send-oncancel-event fix
Summary: fast/events/touch/send-oncancel-event fix
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-08 15:12 PST by Garret Kelly
Modified: 2010-04-19 16:08 PDT (History)
3 users (show)

See Also:

Attachments
Initial patch (1.12 KB, patch)
2010-03-08 15:14 PST, Garret Kelly 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Garret Kelly 2010-03-08 15:12:53 PST 
send-oncancel-event uses js-test-post.js, not js-test-post-function.js, but the test still tries to call successfullyParsed().
Comment 1 Garret Kelly 2010-03-08 15:14:05 PST 
Created attachment 50251 [details]
Initial patch
Comment 2 WebKit Commit Bot 2010-03-09 11:11:13 PST 
Comment on attachment 50251 [details]
Initial patch

Clearing flags on attachment: 50251

Committed r55735: <http://trac.webkit.org/changeset/55735>
Comment 3 WebKit Commit Bot 2010-03-09 11:11:17 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Ben Murdoch 2010-04-19 15:12:06 PDT 
I looked at the history of this test as we are now seeing it fail on Android and it appears that there was an mistake made in copying this test between the fast/events/script-tests directory and fast/events/touch/script-tests in http://trac.webkit.org/changeset/54253 where the link to js-test-post-function.js was replaced with js-test-post.js.

The test needs to use js-test-post-function.js for compatibility on platforms like Android where touch events are passed between threads in an asynchronous manner.

I'd like to revert this patch and fix the error in 54253. I can file a new bug if there are no objections.

Thanks, Ben

PS: We're working to get Android fully upstream so we can get a build bot and prevent these kinds of things in the future.
Comment 5 Ben Murdoch 2010-04-19 16:08:19 PDT 
Filed https://bugs.webkit.org/show_bug.cgi?id=37830