It's only used on Mac, and doesn't seem to be really needed. The performance effect of not wrapping a connection delegate seems minimal, but the effect on code complexity is significant. Besides, we weren't setting it correctly anyway - XMLHttpRequest was hitting the complex code path here.
Created attachment 50250 [details] proposed patch
Comment on attachment 50250 [details] proposed patch r=me assuming there is no measurable performance penalty to the extra level of indirection of every delegate call
Comment on attachment 50250 [details] proposed patch > + d->m_proxy = wkCreateNSURLConnectionDelegateProxy(); Is ownership correct here? The function has create in its name, but I don't see an adopt.
> Is ownership correct here? I think so - there is an explicit release call below. But I'll change to adopt, to avoid current and future confusion. d->m_proxy = wkCreateNSURLConnectionDelegateProxy(); [d->m_proxy.get() setDelegate:ResourceHandle::delegate()]; [d->m_proxy.get() release];
Committed <http://trac.webkit.org/changeset/55688>.