HTMLMediaElement style improvements
Created attachment 50243 [details] Patch
Attachment 50243 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/354047
Comment on attachment 50243 [details] Patch r=me
src/WebMediaPlayerClientImpl.cpp:141: error: ‘WebCore::MediaPlayerClient’ is an inaccessible base of ‘WebCore::HTMLMediaElement’ Frame* frame = static_cast<HTMLMediaElement*>( m_mediaPlayer->mediaPlayerClient())->document()->frame(); m_webMediaPlayer.set(createWebMediaPlayer(this, frame)); If the MediaPlayer is in fact always an HTMLMediaElement, then the class should hold an HTMLMediaElement*, not a MediaPlayer*. It's not safe to downcast.
My mistake, it’s MediaPlayerClient* that is being downcast. If we really need to find out the Frame* then I think we should add a function to MediaPlayerClient* that returns it rather than doing this cast.
Committed r55682: <http://trac.webkit.org/changeset/55682>