Bug 35867 - [chromium]: update Linux layout test scripts for RedHat like systems.
Summary: [chromium]: update Linux layout test scripts for RedHat like systems.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-08 07:56 PST by Adam Langley
Modified: 2010-03-12 08:02 PST (History)
3 users (show)

See Also:

Attachments
patch (2.76 KB, patch)
2010-03-08 07:57 PST, Adam Langley 		no flags Details | Formatted Diff | Diff
patch (2.15 KB, patch)
2010-03-08 08:22 PST, Adam Langley 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Langley 2010-03-08 07:56:18 PST 
[chromium]: update Linux layout test scripts for RedHat like systems.
Comment 1 Adam Langley 2010-03-08 07:57:45 PST 
Created attachment 50221 [details]
patch
Comment 2 Evan Martin 2010-03-08 08:10:05 PST 
+            if self._is_redhat_based():
+                package_name = 'dwdiff'
+            else:
+                package_name = 'wdiff'
+
+            _log.error('    Please install using: "sudo apt-get install ' +
+                       package_name)

Does apt-get work on Redhat?


I kinda wonder if the dwdiff/wdiff distinction could be factored into one place instead of tested twice.


I'm trying to think of a WebKit reviewer who uses Redhat but the GTK guys use Debian I think.
Comment 3 Adam Langley 2010-03-08 08:22:54 PST 
Created attachment 50225 [details]
patch

Evan: you're right. We don't try to have distro specific messages for the other cases so I won't try to here. Linux people can figure it out and I don't think it's worth trying to reflect all that complexity in our scripts for these minor cases.
Comment 4 Adam Langley 2010-03-08 08:26:36 PST 
That wasn't a review to death :) But, in hindsight, trying to maintain the 'apt-get' vs 'yum' messages for everyone and their distro specific package names is just going to rot.

I still need the other changes or I can't run layout tests!
Comment 5 Adam Langley 2010-03-11 07:07:01 PST 
dpranke has been unresponsive for a week and a half now (there was a previous Chromium CL which did the same thing.)

Since moving the layout test running in WebKit has completly broken layout tests on all Fedora systems I'll probably land this as an unreviewed build fix later today.
Comment 6 Dirk Pranke 2010-03-11 11:40:39 PST 
Comment on attachment 50225 [details]
patch

LGTM.
Comment 7 Dirk Pranke 2010-03-11 11:41:09 PST 
Hi Adam,

Sorry for the delay. Somehow I completely missed this bug, although I've been pretty busy fixing other bugs in this stuff for the past three days.
Comment 8 Dimitri Glazkov (Google) 2010-03-11 13:39:50 PST 
Comment on attachment 50225 [details]
patch

rs=me.
Comment 9 WebKit Commit Bot 2010-03-12 08:02:26 PST 
Comment on attachment 50225 [details]
patch

Clearing flags on attachment: 50225

Committed r55903: <http://trac.webkit.org/changeset/55903>
Comment 10 WebKit Commit Bot 2010-03-12 08:02:30 PST 
All reviewed patches have been landed.  Closing bug.