WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
35864
[GStreamer] soften dependency on libsoup in the http src element
https://bugs.webkit.org/show_bug.cgi?id=35864
Summary
[GStreamer] soften dependency on libsoup in the http src element
Philippe Normand
Reported
2010-03-08 07:00:30 PST
So other ports not using libsoup could reuse this code. Not much to do, replace a SoupURI use with KURL and pause/unpause internal soup messages only if libsoup supprt is enabled.
Attachments
proposed patch
(3.33 KB, patch)
2010-03-08 07:16 PST
,
Philippe Normand
gustavo
: review+
gustavo
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Philippe Normand
Comment 1
2010-03-08 07:16:45 PST
Created
attachment 50218
[details]
proposed patch
Gustavo Noronha (kov)
Comment 2
2010-03-08 13:48:03 PST
Comment on
attachment 50218
[details]
proposed patch Looks sane to me, but priv->paused may no longer be true, depending on the network implementation. May warrant a comment?
Philippe Normand
Comment 3
2010-03-09 01:07:22 PST
(In reply to
comment #2
)
> (From update of
attachment 50218
[details]
) > Looks sane to me, but priv->paused may no longer be true, depending on the > network implementation. May warrant a comment?
Why? It will still be assigned to true in webKitWebSrcEnoughDataMainCb. Not sure to understand what comment I should add ;)
Gustavo Noronha (kov)
Comment 4
2010-03-10 09:49:11 PST
(In reply to
comment #3
)
> (In reply to
comment #2
) > > (From update of
attachment 50218
[details]
[details]) > > Looks sane to me, but priv->paused may no longer be true, depending on the > > network implementation. May warrant a comment? > > Why? It will still be assigned to true in webKitWebSrcEnoughDataMainCb. Not > sure to understand what comment I should add ;)
Sorry, I meant that it will be telling lies, since the http download has not been truly paused.
Eric Seidel (no email)
Comment 5
2010-03-15 15:57:59 PDT
Attachment 50218
[details]
was posted by a committer and has review+, assigning to Philippe Normand for commit.
Philippe Normand
Comment 6
2010-03-26 02:00:28 PDT
Landed as
r56615
. Sorry for the delay ;) Also added comments suggesting about pause/unpause.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug