Bug 35864 – [GStreamer] soften dependency on libsoup in the http src element

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Philippe Normand]

So other ports not using libsoup could reuse this code. Not much to do, replace a SoupURI use with KURL and pause/unpause internal soup messages only if libsoup supprt is enabled.

[Philippe Normand]

Created attachment 50218 [details]
proposed patch

[Gustavo Noronha (kov)]

Comment on attachment 50218 [details]
proposed patch

Looks sane to me, but priv->paused may no longer be true, depending on the network implementation. May warrant a comment?

[Philippe Normand]

(In reply to comment #2)
> (From update of attachment 50218 [details])
> Looks sane to me, but priv->paused may no longer be true, depending on the
> network implementation. May warrant a comment?

Why? It will still be assigned to true in webKitWebSrcEnoughDataMainCb. Not sure to understand what comment I should add ;)

[Gustavo Noronha (kov)]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 50218 [details] [details])
> > Looks sane to me, but priv->paused may no longer be true, depending on the
> > network implementation. May warrant a comment?
> 
> Why? It will still be assigned to true in webKitWebSrcEnoughDataMainCb. Not
> sure to understand what comment I should add ;)

Sorry, I meant that it will be telling lies, since the http download has not been truly paused.

[Eric Seidel (no email)]

Attachment 50218 [details] was posted by a committer and has review+, assigning to Philippe Normand for commit.

[Philippe Normand]

Landed as r56615. Sorry for the delay ;) Also added comments suggesting about pause/unpause.