Bug 35864 - [GStreamer] soften dependency on libsoup in the http src element
Summary: [GStreamer] soften dependency on libsoup in the http src element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-08 07:00 PST by Philippe Normand
Modified: 2010-03-26 02:00 PDT (History)
2 users (show)

See Also:

Attachments
proposed patch (3.33 KB, patch)
2010-03-08 07:16 PST, Philippe Normand 		gustavo: review+
gustavo: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2010-03-08 07:00:30 PST 
So other ports not using libsoup could reuse this code. Not much to do, replace a SoupURI use with KURL and pause/unpause internal soup messages only if libsoup supprt is enabled.
Comment 1 Philippe Normand 2010-03-08 07:16:45 PST 
Created attachment 50218 [details]
proposed patch
Comment 2 Gustavo Noronha (kov) 2010-03-08 13:48:03 PST 
Comment on attachment 50218 [details]
proposed patch

Looks sane to me, but priv->paused may no longer be true, depending on the network implementation. May warrant a comment?
Comment 3 Philippe Normand 2010-03-09 01:07:22 PST 
(In reply to comment #2)
> (From update of attachment 50218 [details])
> Looks sane to me, but priv->paused may no longer be true, depending on the
> network implementation. May warrant a comment?

Why? It will still be assigned to true in webKitWebSrcEnoughDataMainCb. Not sure to understand what comment I should add ;)
Comment 4 Gustavo Noronha (kov) 2010-03-10 09:49:11 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 50218 [details] [details])
> > Looks sane to me, but priv->paused may no longer be true, depending on the
> > network implementation. May warrant a comment?
> 
> Why? It will still be assigned to true in webKitWebSrcEnoughDataMainCb. Not
> sure to understand what comment I should add ;)

Sorry, I meant that it will be telling lies, since the http download has not been truly paused.
Comment 5 Eric Seidel (no email) 2010-03-15 15:57:59 PDT 
Attachment 50218 [details] was posted by a committer and has review+, assigning to Philippe Normand for commit.
Comment 6 Philippe Normand 2010-03-26 02:00:28 PDT 
Landed as r56615. Sorry for the delay ;) Also added comments suggesting about pause/unpause.