Bug 35859 - [DRT/Chromium] Add EventSendingController
Summary: [DRT/Chromium] Add EventSendingController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 35902
  Show dependency treegraph
 
Reported: 2010-03-08 03:03 PST by Kent Tamura
Modified: 2010-03-09 03:56 PST (History)
4 users (show)

See Also:


Attachments
Proposed patch (36.73 KB, patch)
2010-03-08 03:05 PST, Kent Tamura
no flags Details | Formatted Diff | Diff
Proposed patch rev.2 (style fix) (36.73 KB, patch)
2010-03-08 03:11 PST, Kent Tamura
no flags Details | Formatted Diff | Diff
Proposed patch rev.3 (style fix) (36.74 KB, patch)
2010-03-08 04:21 PST, Kent Tamura
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-03-08 03:03:52 PST
[DRT/Chromium] Add EventSendingController
Comment 1 Kent Tamura 2010-03-08 03:05:41 PST
Created attachment 50200 [details]
Proposed patch
Comment 2 WebKit Review Bot 2010-03-08 03:10:34 PST
Attachment 50200 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/DumpRenderTree/chromium/EventSendingController.cpp:782:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebKitTools/DumpRenderTree/chromium/EventSendingController.cpp:784:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kent Tamura 2010-03-08 03:11:57 PST
Created attachment 50202 [details]
Proposed patch rev.2 (style fix)
Comment 4 Kent Tamura 2010-03-08 03:12:34 PST
Some notes for the patch:
 - I left ScopedRunnableMethodFactory.  It's defined in task.h and task.h is needed for MessageLoop::current()->postTask().
 - gfx::Point was replaced with WebKit::WebPoint.
Comment 5 WebKit Review Bot 2010-03-08 03:16:50 PST
Attachment 50202 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/DumpRenderTree/chromium/EventSendingController.cpp:782:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebKitTools/DumpRenderTree/chromium/EventSendingController.cpp:784:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Kent Tamura 2010-03-08 04:21:21 PST
Created attachment 50206 [details]
Proposed patch rev.3 (style fix)
Comment 7 Dimitri Glazkov (Google) 2010-03-08 20:51:15 PST
Comment on attachment 50206 [details]
Proposed patch rev.3 (style fix)

ok, except let's rename the file to EventSender.h/cpp
Comment 8 Kent Tamura 2010-03-08 22:49:37 PST
(In reply to comment #7)
> (From update of attachment 50206 [details])
> ok, except let's rename the file to EventSender.h/cpp

Ok, I renamed files, the class name, updated ChangeLog, did check-webkit-style.
Comment 9 Kent Tamura 2010-03-08 22:52:44 PST
Landed as r55713.