Bug 35852 - [DRT/Chromium] Add PlainTextController and TextInputController
Summary: [DRT/Chromium] Add PlainTextController and TextInputController
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Kent Tamura
Depends on:
Blocks: 35902
  Show dependency treegraph
Reported: 2010-03-07 21:41 PST by Kent Tamura
Modified: 2010-03-09 03:56 PST (History)
3 users (show)

See Also:

Proposed patch (17.45 KB, patch)
2010-03-07 21:44 PST, Kent Tamura
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-03-07 21:41:21 PST
[DRT/Chromium] Add PlainTextController and TextInputController
Comment 1 Kent Tamura 2010-03-07 21:44:48 PST
Created attachment 50188 [details]
Proposed patch
Comment 2 Kent Tamura 2010-03-07 21:51:39 PST
- NOTIMPELMENTED() macros in the original code was replaced with notImplemented(). notImplemented() is not one in WebCore/platform/NotImplemented.h, and is defined as empty in config.h for now.
Comment 3 Dimitri Glazkov (Google) 2010-03-08 09:16:08 PST
I think we can just remove notImplemented and replace it with a FIXME: Implement this -- this is what other ports are doing.
Comment 4 Dimitri Glazkov (Google) 2010-03-08 20:52:48 PST
Comment on attachment 50188 [details]
Proposed patch

ok, except replace notImplemented with FIXMEs.
Comment 5 Kent Tamura 2010-03-08 22:39:48 PST
Committed r55712: <http://trac.webkit.org/changeset/55712>
Comment 6 Kent Tamura 2010-03-08 22:40:44 PST
(In reply to comment #4)
> (From update of attachment 50188 [details])
> ok, except replace notImplemented with FIXMEs.

I replaced notImplemented() with FIXME, and landed.