Bug 35845 - webkitpy/init/logtesting.py: Refactor the code for unit-testing logging
Summary: webkitpy/init/logtesting.py: Refactor the code for unit-testing logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Chris Jerdonek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-07 13:07 PST by Chris Jerdonek
Modified: 2010-03-10 10:33 PST (History)
5 users (show)

See Also:

Attachments
Proposed patch (18.24 KB, patch)
2010-03-07 13:47 PST, Chris Jerdonek 		cjerdonek: commit-queue-
Details | Formatted Diff | Diff
Proposed patch 2 (17.38 KB, patch)
2010-03-10 05:00 PST, Chris Jerdonek 		hamaji: review+
cjerdonek: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Jerdonek 2010-03-07 13:07:02 PST 
The code for unit-testing logging can be simplified and cleaned up somewhat.  It can also be documented more.
Comment 1 Chris Jerdonek 2010-03-07 13:47:06 PST 
Created attachment 50176 [details]
Proposed patch

This patch needs to be landed after committing the version-checking patch:

https://bugs.webkit.org/show_bug.cgi?id=35788

So the style bot might not work.
Comment 2 Chris Jerdonek 2010-03-10 05:00:58 PST 
Created attachment 50393 [details]
Proposed patch 2

Revised the patch so it does not depend on another patch being committed.  (The style bot should also work on it now, as a result.)
Comment 3 Shinichiro Hamaji 2010-03-10 06:38:18 PST 
Comment on attachment 50393 [details]
Proposed patch 2

Looks good.
Comment 4 Chris Jerdonek 2010-03-10 10:33:24 PST 
Manually committed:

http://trac.webkit.org/changeset/55786