RESOLVED FIXED 35840
Update QtWebKit library name under Windows in webkitdir.pm so that run-launcher can work. 
https://bugs.webkit.org/show_bug.cgi?id=35840
Summary Update QtWebKit library name under Windows in webkitdir.pm so that run-launch...
Daniel Bates
Reported 2010-03-06 21:28:58 PST
We should update the library name in webkitdir.pm to match the change made in changeset 53924 <http://trac.webkit.org/changeset/53924> so that run-launcher can find the built QtWebKit library and launch the QtLauncher application.
Attachments
Patch (1.57 KB, patch)
2010-03-08 08:51 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (1.64 KB, patch)
2010-03-09 22:24 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2010-03-08 08:51:04 PST
Created attachment 50226 [details] Patch
Jocelyn Turcotte
Comment 2 2010-03-09 01:23:37 PST
> We should update the library name in webkitdir.pm to match the change made in > changeset 53924 <http://trac.webkit.org/changeset/53924> so that run-launcher > can find the built QtWebKit library and launch the QtLauncher application. Agreed, the 'd' suffix is only in debug so you might want to add something like if configuration() eq "Debug"(In reply to comment #0)
Daniel Bates
Comment 3 2010-03-09 08:02:24 PST
Comment on attachment 50226 [details] Patch Will update patch
Daniel Bates
Comment 4 2010-03-09 22:24:52 PST
Created attachment 50371 [details] Patch Updated patch to only add the "d" suffix if its a debug Windows build.
Tor Arne Vestbø
Comment 5 2010-03-10 06:44:02 PST
Please follow the QtWebKit bug reporting guidelines when reporting bugs. See http://trac.webkit.org/wiki/QtWebKitBugs Specifically: - The 'QtWebKit' component should only be used for bugs/features in the public QtWebKit API layer, not to signify that the bug is specific to the Qt port of WebKit http://trac.webkit.org/wiki/QtWebKitBugs#Component - Add the keyword 'Qt' to signal that it's a Qt-related bug http://trac.webkit.org/wiki/QtWebKitBugs#Keywords
Daniel Bates
Comment 6 2010-03-10 20:10:21 PST
Comment on attachment 50371 [details] Patch Clearing flags on attachment: 50371 Committed r55829: <http://trac.webkit.org/changeset/55829>
Daniel Bates
Comment 7 2010-03-10 20:10:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.