Bug 35840 - Update QtWebKit library name under Windows in webkitdir.pm so that run-launcher can work.
Summary: Update QtWebKit library name under Windows in webkitdir.pm so that run-launch...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-03-06 21:28 PST by Daniel Bates
Modified: 2010-03-10 20:10 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.57 KB, patch)
2010-03-08 08:51 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (1.64 KB, patch)
2010-03-09 22:24 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2010-03-06 21:28:58 PST 
We should update the library name in webkitdir.pm to match the change made in changeset 53924 <http://trac.webkit.org/changeset/53924> so that run-launcher can find the built QtWebKit library and launch the QtLauncher application.
Comment 1 Daniel Bates 2010-03-08 08:51:04 PST 
Created attachment 50226 [details]
Patch
Comment 2 Jocelyn Turcotte 2010-03-09 01:23:37 PST 
> We should update the library name in webkitdir.pm to match the change made in
> changeset 53924 <http://trac.webkit.org/changeset/53924> so that run-launcher
> can find the built QtWebKit library and launch the QtLauncher application.

Agreed, the 'd' suffix is only in debug so you might want to add something like
if configuration() eq "Debug"(In reply to comment #0)
Comment 3 Daniel Bates 2010-03-09 08:02:24 PST 
Comment on attachment 50226 [details]
Patch

Will update patch
Comment 4 Daniel Bates 2010-03-09 22:24:52 PST 
Created attachment 50371 [details]
Patch

Updated patch to only add the "d" suffix if its a debug Windows build.
Comment 5 Tor Arne Vestbø 2010-03-10 06:44:02 PST 
Please follow the QtWebKit bug reporting guidelines when reporting bugs.

See http://trac.webkit.org/wiki/QtWebKitBugs

Specifically:

  - The 'QtWebKit' component should only be used for bugs/features in the
    public QtWebKit API layer, not to signify that the bug is specific to
    the Qt port of WebKit

      http://trac.webkit.org/wiki/QtWebKitBugs#Component

  - Add the keyword 'Qt' to signal that it's a Qt-related bug

      http://trac.webkit.org/wiki/QtWebKitBugs#Keywords
Comment 6 Daniel Bates 2010-03-10 20:10:21 PST 
Comment on attachment 50371 [details]
Patch

Clearing flags on attachment: 50371

Committed r55829: <http://trac.webkit.org/changeset/55829>
Comment 7 Daniel Bates 2010-03-10 20:10:27 PST 
All reviewed patches have been landed.  Closing bug.