RESOLVED FIXED 35835
test-webkitpy: Adjust logging code so that "side-effect" messages do not render to the screen 
https://bugs.webkit.org/show_bug.cgi?id=35835
Summary test-webkitpy: Adjust logging code so that "side-effect" messages do not rend...
Chris Jerdonek
Reported 2010-03-06 16:42:30 PST
Currently, if we configure logging in test-webkitpy, then spurious log messages will get logged to the screen as a side effect of the code that the unit tests are executing. We should suppress those spurious log messages. The solution here will involve something like setting the "propagate" attribute on any test loggers to False so that the log messages will not propagate up to the root logger and be logged.
Attachments
Proposed patch (2.62 KB, patch)
2010-03-07 08:39 PST, Chris Jerdonek 		abarth: review+
cjerdonek: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Jerdonek
Comment 1 2010-03-07 08:39:00 PST
Created attachment 50173 [details] Proposed patch
Adam Barth
Comment 2 2010-03-13 02:18:59 PST
Comment on attachment 50173 [details] Proposed patch Python's logging is much more awesome than what Eric cooked up on his own. Thanks for educating us in the ways of Python.
Chris Jerdonek
Comment 3 2010-03-13 15:50:36 PST
Manually committed (via git svn dcommit): http://trac.webkit.org/changeset/55971
Note You need to log in before you can comment on or make changes to this bug.